From: Alex Elder <elder@dreamhost.com>
To: Sage Weil <sage@newdream.net>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 4/4] libceph: a few small changes
Date: Fri, 02 Mar 2012 15:28:59 -0800 [thread overview]
Message-ID: <4F5157BB.1050108@dreamhost.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1203021339350.6413@cobra.newdream.net>
On 03/02/2012 01:40 PM, Sage Weil wrote:
>> + default:
>> > + WARN(1, "unexpected socket state (%d)", sk->sk_state);
>> > + break;
>> > }
> This is a red herring... the switch isn't meant to be exhaustive, only to
> catch the interesting (shutdown) states. I think #2099 can be closed as
> well.
That's pretty funny. Didn't I open that bug?
I will drop the WARN() but will add a comment to indicate it's
explicitly not meant to cover all expected cases.
-Alex
next prev parent reply other threads:[~2012-03-02 23:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 4:44 [PATCH 0/4] libceph: miscellaneous cleanups Alex Elder
2012-02-29 4:46 ` [PATCH 1/4] libceph: make ceph_msgr_wq private Alex Elder
2012-02-29 4:46 ` [PATCH 2/4] libceph: encapsulate some messenger cleanup code Alex Elder
2012-02-29 17:44 ` [PATCH, v2] " Alex Elder
2012-02-29 4:46 ` [PATCH 3/4] libceph: make ceph_tcp_connect() return int Alex Elder
2012-02-29 4:46 ` [PATCH 4/4] libceph: a few small changes Alex Elder
2012-03-02 21:40 ` Sage Weil
2012-03-02 23:28 ` Alex Elder [this message]
2012-03-02 21:42 ` [PATCH 0/4] libceph: miscellaneous cleanups Sage Weil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5157BB.1050108@dreamhost.com \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.