From: Alex Elder <elder@dreamhost.com>
To: Sage Weil <sage@newdream.net>
Cc: ceph-devel@vger.kernel.org
Subject: Re: [PATCH 0/3] libceph: clean up some code involving CRCs
Date: Fri, 02 Mar 2012 15:30:27 -0800 [thread overview]
Message-ID: <4F515813.2000704@dreamhost.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1203021347240.6413@cobra.newdream.net>
On 03/02/2012 01:47 PM, Sage Weil wrote:
> These look good.. but where is the crc bug actually fixed? Not seeing
> that patch...
I haven't addressed it yet. Soon, very soon...
-Alex
> Reviewed-by: Sage Weil<sage@newdream.net>
>
> On Tue, 28 Feb 2012, Alex Elder wrote:
>
>> Rename a few variables so it's clearer which indicate that a
>> CRC should be computed and which hold an actual CRC value.
>> Separate CRC calculation from byte swapping to improve
>> readability. And move some code that runs on only on
>> the last pass through a couple of loops outside the loop
>> body.
>>
>> -Alex
>> --
>> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>>
prev parent reply other threads:[~2012-03-02 23:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-29 4:49 [PATCH 0/3] libceph: clean up some code involving CRCs Alex Elder
2012-02-29 4:50 ` [PATCH 1/3] libceph: use "do" in CRC-related Boolean variables Alex Elder
2012-02-29 4:50 ` [PATCH 2/3] libceph: separate CRC calculation from byte swapping Alex Elder
2012-02-29 4:50 ` [PATCH 3/3] libceph: do crc calculations outside loop Alex Elder
2012-03-02 21:47 ` [PATCH 0/3] libceph: clean up some code involving CRCs Sage Weil
2012-03-02 23:30 ` Alex Elder [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F515813.2000704@dreamhost.com \
--to=elder@dreamhost.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@newdream.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.