From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:37853)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1S3lSH-0006iA-FM
	for qemu-devel@nongnu.org; Sat, 03 Mar 2012 04:40:46 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1S3lRx-0003PF-Ew
	for qemu-devel@nongnu.org; Sat, 03 Mar 2012 04:40:45 -0500
Received: from isrv.corpit.ru ([86.62.121.231]:54185)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <mjt@tls.msk.ru>) id 1S3lRx-0003Os-87
	for qemu-devel@nongnu.org; Sat, 03 Mar 2012 04:40:25 -0500
Message-ID: <4F51E706.7010503@msgid.tls.msk.ru>
Date: Sat, 03 Mar 2012 13:40:22 +0400
From: Michael Tokarev <mjt@tls.msk.ru>
MIME-Version: 1.0
References: <1330756709-12781-1-git-send-email-ronniesahlberg@gmail.com>
	<1330756709-12781-2-git-send-email-ronniesahlberg@gmail.com>
In-Reply-To: <1330756709-12781-2-git-send-email-ronniesahlberg@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH] Change library from libiscsi to
 libiscsiclient to match library rename in libiscsi
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ronnie Sahlberg <ronniesahlberg@gmail.com>
Cc: kwolf@redhat.com, qemu-devel@nongnu.org

On 03.03.2012 10:38, Ronnie Sahlberg wrote:
> Signed-off-by: Ronnie Sahlberg <ronniesahlberg@gmail.com>
> ---
>  configure |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/configure b/configure
> index fb0e18e..294c0c1 100755
> --- a/configure
> +++ b/configure
> @@ -2503,9 +2503,9 @@ if test "$libiscsi" != "no" ; then
>  #include <iscsi/iscsi.h>
>  int main(void) { iscsi_create_context(""); return 0; }
>  EOF
> -  if compile_prog "-Werror" "-liscsi" ; then
> +  if compile_prog "-Werror" "-liscsiclient" ; then
>      libiscsi="yes"
> -    LIBS="$LIBS -liscsi"
> +    LIBS="$LIBS -liscsiclient"
>    else
>      if test "$libiscsi" = "yes" ; then
>        feature_not_found "libiscsi"

Shouldn't we rename the feature and the --with/--without
name too here?  This appears to be partial "fix" for the
name change.

For the feature, I'd suggest using --with-iscsi instead of
--with-libiscsiclient.  But... dunno.

Thanks,

/mjt