From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S3qXp-0001dA-1Z for mharc-grub-devel@gnu.org; Sat, 03 Mar 2012 10:06:49 -0500 Received: from eggs.gnu.org ([208.118.235.92]:39067) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3qXk-0001br-H0 for grub-devel@gnu.org; Sat, 03 Mar 2012 10:06:46 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3qXi-0005N5-Bt for grub-devel@gnu.org; Sat, 03 Mar 2012 10:06:44 -0500 Received: from mail-ey0-f169.google.com ([209.85.215.169]:36263) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3qXi-0005Mq-2N for grub-devel@gnu.org; Sat, 03 Mar 2012 10:06:42 -0500 Received: by eaal1 with SMTP id l1so962580eaa.0 for ; Sat, 03 Mar 2012 07:06:40 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.14.182.134 as permitted sender) client-ip=10.14.182.134; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.14.182.134 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.14.182.134]) by 10.14.182.134 with SMTP id o6mr8023751eem.40.1330787200182 (num_hops = 1); Sat, 03 Mar 2012 07:06:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=HIqQpJ1Su+QWvo4TRQFZFu0kZfcqZe+EqhUhB5aFMCE=; b=zv9M/t0H/hWUbL3VeAyfyNJ3RZadrhboy9H1Ht6CMQ/zuTlQKjRlgNXFyuUEChTTV8 gC4LBQeD58Zb/KpPXPGmr2Mjkt5J7YAy+FvaxzgsQ2CFR9iHFJtlQrqjsQ+i/OMc6l/K 93xr92vU0MMOHzmrjdGw8LqJekHXfxeql0Ee+AybI80+zrHpep4AT7o07QXgb4ThkJ5R siiZ33mjZhdAiUF9laSqllyj821yRs0/g3gV5SvR1MTwH1MS3/03jgguMaKY6darhFMF ew9wH/F0+69j5dq7z75vsukG4CYK/uZbH3e6KQ4t+zpNRGYfutCDmQgy01vK9ZBqeIPt o7Qg== Received: by 10.14.182.134 with SMTP id o6mr6167914eem.40.1330787200086; Sat, 03 Mar 2012 07:06:40 -0800 (PST) Received: from debian.x201.phnet (103-234.197-178.cust.bluewin.ch. [178.197.234.103]) by mx.google.com with ESMTPS id u11sm35155535eeb.1.2012.03.03.07.06.38 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Mar 2012 07:06:39 -0800 (PST) Message-ID: <4F52337C.4050909@gmail.com> Date: Sat, 03 Mar 2012 16:06:36 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: Device instability, gettext and default References: <4F521E88.7070401@gmail.com> <4F522FFC.20308@anvo-it.de> In-Reply-To: <4F522FFC.20308@anvo-it.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.215.169 Cc: Andreas Vogel X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2012 15:06:46 -0000 On 03.03.2012 15:51, Andreas Vogel wrote: > Vladimir, > > this enhancement is part of my patches which i sent some days ago..... > > I introduced an option "--label STRING" which will be used for display > if it's set and which can also have environment variables (another > part of my patches). > > It's just a matter of taste though if to use a new option --id for an > invariant menu id or to use the actual menuentry title as the > invariant id and to have a new option --label for the display string. > Both ways provide backward compatibility. > > BTW, I just wonder a little that you refused my enhancements due to > code freeze but are now enhancing anyway ;-) > The reason is simple: you submitted a huge patch for several things, most of them new features. If you had submitted small patches each making one consistent logical change (but it may depend on other changes) then I would have reviewed the ones fixing bugs (like the one you describe). That's the general truth that 20 small patches go in much faster than one patch big patch doing 20 things put together. > Andreas > > > Am 03.03.2012 14:37, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: >> Hello, all. Currently we use and recommend using the title for >> default variable. It has however following problems: >> 1) When device names change the title changes (because of the "(on >> $device)" part) >> 2) If user changes locale the part ", with" gets translated and again >> the title changes >> Attached patch changes it to the use of IDs specified by --id but >> keeps title possiblity for backward compatibility. Any comments? >> >> >> >> _______________________________________________ >> Grub-devel mailing list >> Grub-devel@gnu.org >> https://lists.gnu.org/mailman/listinfo/grub-devel > > -- > Andreas Vogel > Dipl.-Inform. > Hellerweg 60 > 73728 Esslingen > Germany > ____________________________________________ > E-Mail:Andreas.Vogel@anvo-it.de > Office: +49 (711) 937 1742 > FAX: +49 (711) 937 1745 > Mobile: +49 (172) 730 7440 > > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel -- Regards Vladimir 'φ-coder/phcoder' Serbinenko