From: Andreas Vogel <Andreas.Vogel@anvo-it.de>
To: The development of GNU GRUB <grub-devel@gnu.org>
Subject: Re: Device instability, gettext and default
Date: Sat, 03 Mar 2012 20:48:33 +0100 [thread overview]
Message-ID: <4F527591.8030406@anvo-it.de> (raw)
In-Reply-To: <4F521E88.7070401@gmail.com>
I was thinking about your proposal again and I think your idea
introducing a --id option is better than my idea having a --label option.
> === modified file 'include/grub/menu.h'
> --- include/grub/menu.h 2011-01-10 22:27:58 +0000
> +++ include/grub/menu.h 2012-03-03 12:11:30 +0000
> @@ -32,6 +32,9 @@
> /* The title name. */
> const char *title;
>
> + /* The identifier. */
> + const char *id;
> +
> /* If set means not everybody is allowed to boot this entry. */
> int restricted;
>
Why are all the string variables declared as "const char *"? In my
opinion the const qualifier is not useful/needed.
next prev parent reply other threads:[~2012-03-03 19:48 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 13:37 Device instability, gettext and default Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-03 14:27 ` Jordi Mallach
2012-03-03 14:51 ` Andreas Vogel
2012-03-03 15:06 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-03 19:48 ` Andreas Vogel [this message]
2012-03-03 20:04 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-03 20:08 ` Andreas Vogel
2012-03-03 20:10 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-04 23:51 ` Andreas Vogel
2012-03-05 0:03 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-05 0:20 ` Andreas Vogel
2012-03-05 0:34 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-05 11:51 ` Andreas Vogel
2012-03-05 12:37 ` Vladimir 'φ-coder/phcoder' Serbinenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F527591.8030406@anvo-it.de \
--to=andreas.vogel@anvo-it.de \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.