From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S3vBe-0000XT-Jx for mharc-grub-devel@gnu.org; Sat, 03 Mar 2012 15:04:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:57685) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3vBb-0000XM-EB for grub-devel@gnu.org; Sat, 03 Mar 2012 15:04:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3vBZ-0002z3-5Z for grub-devel@gnu.org; Sat, 03 Mar 2012 15:04:10 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:58904) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3vBY-0002x7-SS for grub-devel@gnu.org; Sat, 03 Mar 2012 15:04:09 -0500 Received: by eeke53 with SMTP id e53so1053962eek.0 for ; Sat, 03 Mar 2012 12:04:06 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.213.15.14 as permitted sender) client-ip=10.213.15.14; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.213.15.14 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.213.15.14]) by 10.213.15.14 with SMTP id i14mr171700eba.209.1330805046726 (num_hops = 1); Sat, 03 Mar 2012 12:04:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=SKPb+LpnLie5c6Uz5vo6QyvMCmnhFFD60cEpreIuJI4=; b=RYWJjVEUJWisRzgC98KMzc48gI3Kw94dQa+4Rj8uQAsol98nNrsPkSZjsNUwucgeKr xXpYNbade7TQuztuqCGJdSVRpCzdExFlDF3BnIkh/ECt/sTABItsC30qyaA3dRYBsK8p ORuhrxVA+/pyFbwL9hiSYwqTuqhk1y5Rzkd4boZGsXR946AtjsQ9FbT8/f+jbGF7wfBE gYfnDNORstHT3osb05wzC0mFModHK/wCnBtpBsCA5ch69m1slnMvKg36pJ5bLrAdz2iU 2YepahyNn46bOIOo7knwrPip7Ra7w9oTt6KW6e4PrM3zzg8k4U1uTsPdXUjFabQsDuil uxdQ== Received: by 10.213.15.14 with SMTP id i14mr123296eba.209.1330805046626; Sat, 03 Mar 2012 12:04:06 -0800 (PST) Received: from debian.x201.phnet (127-109.62-81.cust.bluewin.ch. [81.62.109.127]) by mx.google.com with ESMTPS id u9sm38206218eem.11.2012.03.03.12.04.04 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Mar 2012 12:04:05 -0800 (PST) Message-ID: <4F527933.50105@gmail.com> Date: Sat, 03 Mar 2012 21:04:03 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: Device instability, gettext and default References: <4F521E88.7070401@gmail.com> <4F527591.8030406@anvo-it.de> In-Reply-To: <4F527591.8030406@anvo-it.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.83.41 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2012 20:04:13 -0000 On 03.03.2012 20:48, Andreas Vogel wrote: > I was thinking about your proposal again and I think your idea > introducing a --id option is better than my idea having a --label option. > >> === modified file 'include/grub/menu.h' >> --- include/grub/menu.h 2011-01-10 22:27:58 +0000 >> +++ include/grub/menu.h 2012-03-03 12:11:30 +0000 >> @@ -32,6 +32,9 @@ >> /* The title name. */ >> const char *title; >> >> + /* The identifier. */ >> + const char *id; >> + >> /* If set means not everybody is allowed to boot this entry. */ >> int restricted; >> > Why are all the string variables declared as "const char *"? In my > opinion the const qualifier is not useful/needed. This string is used for quite long time in different functions and the small corruption can lead to difficult to trace bugs. With const compiler takes care of checking them. > > _______________________________________________ > Grub-devel mailing list > Grub-devel@gnu.org > https://lists.gnu.org/mailman/listinfo/grub-devel > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko