From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S3w5I-0001U7-0L for mharc-grub-devel@gnu.org; Sat, 03 Mar 2012 16:01:44 -0500 Received: from eggs.gnu.org ([208.118.235.92]:38914) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3w5E-0001Tz-CI for grub-devel@gnu.org; Sat, 03 Mar 2012 16:01:42 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3w5C-0004Ts-Os for grub-devel@gnu.org; Sat, 03 Mar 2012 16:01:39 -0500 Received: from mail-ey0-f169.google.com ([209.85.215.169]:45751) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3w5C-0004Tk-GT for grub-devel@gnu.org; Sat, 03 Mar 2012 16:01:38 -0500 Received: by eaal1 with SMTP id l1so1027202eaa.0 for ; Sat, 03 Mar 2012 13:01:36 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.14.32.205 as permitted sender) client-ip=10.14.32.205; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.14.32.205 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.14.32.205]) by 10.14.32.205 with SMTP id o53mr8627395eea.47.1330808496540 (num_hops = 1); Sat, 03 Mar 2012 13:01:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=lQXp/jP48bXX03G+CATImkes9JjgXEplfX09Lki4eIM=; b=CeXjkzjhIsSceXFKz4U0rBWJAEmSKEq9pQuK8deh+DKtmFIQpFjwOnZE+7ou+2EzYB oWhB8PasVJgnrA4+0aB88pXPqlycK+DZd97JXVJQS/t5DpbixGgK8Q/qpOuqyAnG/YBk dg39CupGYSAN0MasmFz4DIV9JTO4hpfQwjBJCOsxWIm0fEFLEb3AVMg6yxtGNQPBmJi5 n4pSklSd/PEHjGeTwSNrjLlXk8nKRQsL3JNT/w0opXfbRxE+cZbDosGPt9V+p8FncOe2 C8gSCsz7sXPXZjpqv+xeuNwlcDdtQc4bxKQDZWtEw6/jLwJo7GfpS3G1sDc5vD4QUJ0f Cr8g== Received: by 10.14.32.205 with SMTP id o53mr6601587eea.47.1330808496477; Sat, 03 Mar 2012 13:01:36 -0800 (PST) Received: from debian.x201.phnet (127-109.62-81.cust.bluewin.ch. [81.62.109.127]) by mx.google.com with ESMTPS id z47sm12999560een.5.2012.03.03.13.01.34 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Mar 2012 13:01:35 -0800 (PST) Message-ID: <4F5286AD.1000506@gmail.com> Date: Sat, 03 Mar 2012 22:01:33 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: grub-devel@gnu.org Subject: Re: [PATCH] Enhanced hotkey handling for menuentry References: <4F528288.7030200@anvo-it.de> In-Reply-To: <4F528288.7030200@anvo-it.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.215.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2012 21:01:42 -0000 On 03.03.2012 21:43, Andreas Vogel wrote: > Here is a small patch which enhances the hotkey handling for menu entries. Could you use GNU style? You miss the spaces before braces. Comments have to be full sentences, start with uppercase and end with a dot followed by 2 spaces. Comment /*NOTHING*/ is not useful. > - new static function parse_key() > - hotkey aliases are now case insensitive > - additional hotkey aliases All added aliases conflict with normal function of these keys (arrows and pages) > - handling now and modifiers for hotkeys Could you change to the emacs notation? Shift flag isn't valid with alphanumeric keys. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko