From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S3wRW-0007ro-O8 for mharc-grub-devel@gnu.org; Sat, 03 Mar 2012 16:24:42 -0500 Received: from eggs.gnu.org ([208.118.235.92]:37372) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3wRU-0007ri-3m for grub-devel@gnu.org; Sat, 03 Mar 2012 16:24:41 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3wRS-0000YR-Gi for grub-devel@gnu.org; Sat, 03 Mar 2012 16:24:39 -0500 Received: from mail-ey0-f169.google.com ([209.85.215.169]:40480) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3wRS-0000YD-8G for grub-devel@gnu.org; Sat, 03 Mar 2012 16:24:38 -0500 Received: by eaal1 with SMTP id l1so1030617eaa.0 for ; Sat, 03 Mar 2012 13:24:36 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.14.53.7 as permitted sender) client-ip=10.14.53.7; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.14.53.7 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.14.53.7]) by 10.14.53.7 with SMTP id f7mr8394045eec.105.1330809876337 (num_hops = 1); Sat, 03 Mar 2012 13:24:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:subject:references :in-reply-to:content-type:content-transfer-encoding; bh=n0tyIaEi8WnNIGott20hqsGUQBWpFAit8TUD2E6km/8=; b=PofNQMOGB8+is3pJN+pjB76qRT4SfiBFio7Jnp0+rdRvniEzwHX4kBeUBecIYK6Mha ZQHfAHjQ7oLAN9xBJWzCLSlJo9QPZ3yhtrRFr9eSGWSnoskrQK+J7wiIGKnuXTfoz67i 4MfKuo/zfA98sMwGyvO6ZXu2IZJdToekOGSpmMj0ymEQEhLw+8tccBMH2u7trMX1N2K7 jyr5P98IFPPFjWBKzENrJXlKA3a2N2GrFdlcUVv7XQltmJg6EFobMtQ+Khfi3F00TUya gTYJZt3n40R2V46cW0oTW1RwCVNHuhpXKbvgLgbhEIgRHhyw1kpoHV6UZ6nxB8i/v7S7 HCFw== Received: by 10.14.53.7 with SMTP id f7mr6395549eec.105.1330809876208; Sat, 03 Mar 2012 13:24:36 -0800 (PST) Received: from debian.x201.phnet (127-109.62-81.cust.bluewin.ch. [81.62.109.127]) by mx.google.com with ESMTPS id r5sm39081298eef.6.2012.03.03.13.24.34 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 03 Mar 2012 13:24:35 -0800 (PST) Message-ID: <4F528C11.7060409@gmail.com> Date: Sat, 03 Mar 2012 22:24:33 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: The development of GRUB 2 Subject: Re: [PATCH] Using enum symbols as indices into menuentry options References: <4F528409.2010901@anvo-it.de> <4F528713.2000506@gmail.com> <4F528960.7040308@anvo-it.de> In-Reply-To: <4F528960.7040308@anvo-it.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 209.85.215.169 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2012 21:24:41 -0000 Keep list CC'ed. On 03.03.2012 22:13, Andreas Vogel wrote: >> On 03.03.2012 21:50, Andreas Vogel wrote: >>> +enum options >>> + { >> Please don't define a type here, especially that a type "options" can >> easily conflict with something else. >> > I reused that idea from commands/search_wrap.c and basically i liked > that idea. Just use an anonymous enum. -- Regards Vladimir 'φ-coder/phcoder' Serbinenko