From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S3wXg-0000Q3-B8 for mharc-grub-devel@gnu.org; Sat, 03 Mar 2012 16:31:04 -0500 Received: from eggs.gnu.org ([208.118.235.92]:46889) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3wXe-0000Px-7l for grub-devel@gnu.org; Sat, 03 Mar 2012 16:31:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S3wXc-0001Pt-HJ for grub-devel@gnu.org; Sat, 03 Mar 2012 16:31:01 -0500 Received: from wp191.webpack.hosteurope.de ([80.237.132.198]:34398) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S3wXc-0001Pk-9O for grub-devel@gnu.org; Sat, 03 Mar 2012 16:31:00 -0500 Received: from p54ba694b.dip.t-dialin.net ([84.186.105.75] helo=neptun.omega.ssw.de); authenticated by wp191.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1S3wXa-0004Xu-3R; Sat, 03 Mar 2012 22:30:58 +0100 Received: from localhost (localhost [127.0.0.1]) by neptun.omega.ssw.de (Postfix) with ESMTP id 5DD71E180A8 for ; Sat, 3 Mar 2012 22:30:57 +0100 (CET) X-Virus-Scanned: amavisd-new at omega.ssw.de Received: from neptun.omega.ssw.de ([127.0.0.1]) by localhost (neptun.omega.ssw.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OSh+GwVjUd06 for ; Sat, 3 Mar 2012 22:30:45 +0100 (CET) Received: from [192.168.2.43] (p640.fritz.box [192.168.2.43]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by neptun.omega.ssw.de (Postfix) with ESMTP id 8D5E2E180A7 for ; Sat, 3 Mar 2012 22:30:45 +0100 (CET) Message-ID: <4F528D83.4020603@anvo-it.de> Date: Sat, 03 Mar 2012 22:30:43 +0100 From: Andreas Vogel User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: [PATCH] Enhanced hotkey handling for menuentry References: <4F528288.7030200@anvo-it.de> <4F5286AD.1000506@gmail.com> In-Reply-To: <4F5286AD.1000506@gmail.com> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-bounce-key: webpack.hosteurope.de; andreas.vogel@anvo-it.de; 1330810260; 9a2e49c5; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.237.132.198 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 03 Mar 2012 21:31:03 -0000 > On 03.03.2012 21:43, Andreas Vogel wrote: >> Here is a small patch which enhances the hotkey handling for menu >> entries. > Could you use GNU style? You miss the spaces before braces. Sure. Missed by accident. > Comments have to be full sentences, start with uppercase and end with > a dot followed by 2 spaces. Wow... ok. > Comment /*NOTHING*/ is not useful. I disagree, because it's more clear that this is an intentionally left empty body. But it's a matter of taste and I obey. >> - new static function parse_key() >> - hotkey aliases are now case insensitive >> - additional hotkey aliases > All added aliases conflict with normal function of these keys (arrows > and pages) Yes, I know. But it doesn't harm anyway and it might be useful to have the code already in case the use of the keys change in the future. Anyway, if you insist of leaving them out i'll obey. >> - handling now and modifiers for hotkeys > Could you change to the emacs notation? What is the emacs notation? I have no idea. > Shift flag isn't valid with alphanumeric keys. Ah, ok. Am I right that it's enough just not to set the SHIFT mask in case isalnum() is true?