From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:53919) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4EZl-0007n5-Pj for qemu-devel@nongnu.org; Sun, 04 Mar 2012 11:46:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4EZk-0001Nc-3Q for qemu-devel@nongnu.org; Sun, 04 Mar 2012 11:46:25 -0500 Received: from cantor2.suse.de ([195.135.220.15]:60526 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4EZj-0001NS-TK for qemu-devel@nongnu.org; Sun, 04 Mar 2012 11:46:24 -0500 Message-ID: <4F539C4E.2090304@suse.de> Date: Sun, 04 Mar 2012 17:46:06 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1330043012-30556-1-git-send-email-david@gibson.dropbear.id.au> <1330043012-30556-7-git-send-email-david@gibson.dropbear.id.au> <4F4CC96B.6040003@redhat.com> <1330465707.11728.29.camel@pasglop> <4F5348CE.8070909@redhat.com> <1330861999.11728.79.camel@pasglop> In-Reply-To: <1330861999.11728.79.camel@pasglop> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 6/6] kvm: Fix dirty tracking with large kernel page size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Benjamin Herrenschmidt Cc: Marcelo Tosatti , Alexander Graf , qemu-devel@nongnu.org, Avi Kivity , anthony@codemonkey.ws, David Gibson Am 04.03.2012 12:53, schrieb Benjamin Herrenschmidt: > On Sun, 2012-03-04 at 12:49 +0200, Avi Kivity wrote: >> On 02/28/2012 11:48 PM, Benjamin Herrenschmidt wrote: >>> On Tue, 2012-02-28 at 14:32 +0200, Avi Kivity wrote: >>> >>>> What if TARGET_PAGE_SIZE > getpagesize()? Or is that impossible? >>> >>> We have yet to encounter such a case. It's not currently possible on >>> power (some old embedded chips could do 1K and 2K page sizes in the T= LB >>> iirc but we never supported that in Linux and it's being phased out i= n >>> HW). >>> >>> I suggest that gets dealt with when/if it needs to, which means proba= bly >>> never :-) >> >> Doesn't ppc support both 4k and 64k pages? Suppose you run a 4k guest >> on a 64k host? >> >> Maybe I'm misremembering or misunderstanding something. > TARGET_PAGE_SIZE in qemu is always 4k for powerpc, it's a compile time > #define. Except for ppcemb-softmmu (1k), which is irrelevant for KVM AFAIU. Maybe just add an assert and be done with it? For the record, I am hoping to get rid of some of those cpu.h defines in a later stage of QOM'ification. Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg