From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S4LD3-0002nX-FG for mharc-grub-devel@gnu.org; Sun, 04 Mar 2012 18:51:25 -0500 Received: from eggs.gnu.org ([208.118.235.92]:35778) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4LD1-0002k8-KE for grub-devel@gnu.org; Sun, 04 Mar 2012 18:51:24 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4LCz-0004Yj-Tt for grub-devel@gnu.org; Sun, 04 Mar 2012 18:51:23 -0500 Received: from wp191.webpack.hosteurope.de ([80.237.132.198]:35834) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4LCz-0004YR-OG for grub-devel@gnu.org; Sun, 04 Mar 2012 18:51:21 -0500 Received: from p54ba7a6e.dip.t-dialin.net ([84.186.122.110] helo=neptun.omega.ssw.de); authenticated by wp191.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1S4LCx-0006IA-PW; Mon, 05 Mar 2012 00:51:19 +0100 Received: from localhost (localhost [127.0.0.1]) by neptun.omega.ssw.de (Postfix) with ESMTP id BE6B3E180A8; Mon, 5 Mar 2012 00:51:18 +0100 (CET) X-Virus-Scanned: amavisd-new at omega.ssw.de Received: from neptun.omega.ssw.de ([127.0.0.1]) by localhost (neptun.omega.ssw.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vpeStolic7BO; Mon, 5 Mar 2012 00:51:08 +0100 (CET) Received: from [192.168.2.43] (p640.fritz.box [192.168.2.43]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by neptun.omega.ssw.de (Postfix) with ESMTP id 228F2E180A7; Mon, 5 Mar 2012 00:51:08 +0100 (CET) Message-ID: <4F53FFE7.2060407@anvo-it.de> Date: Mon, 05 Mar 2012 00:51:03 +0100 From: Andreas Vogel User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: The development of GNU GRUB Subject: Re: Device instability, gettext and default References: <4F521E88.7070401@gmail.com> In-Reply-To: <4F521E88.7070401@gmail.com> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-bounce-key: webpack.hosteurope.de; andreas.vogel@anvo-it.de; 1330905081; a38cf024; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.237.132.198 Cc: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 04 Mar 2012 23:51:24 -0000 Am 03.03.2012 14:37, schrieb Vladimir '=CF=86-coder/phcoder' Serbinenko: > =3D=3D=3D modified file 'grub-core/commands/menuentry.c' > --- grub-core/commands/menuentry.c 2012-02-26 16:28:05 +0000 > +++ grub-core/commands/menuentry.c 2012-03-03 12:11:30 +0000 > @@ -36,6 +36,8 @@ > N_("Keyboard key to quickly boot this entry."), N_("KEYBOARD_KEY"= ), ARG_TYPE_STRING}, > {"source", 4, 0, > N_("Use STRING as menu entry body."), N_("STRING"), ARG_TYPE_STRI= NG}, > + {"id", 1, GRUB_ARG_OPTION_REPEATABLE, > + N_("Menu entry identifier."), N_("STRING"), ARG_TYPE_STRING}, > {0, 0, 0, 0, 0, 0} > }; 1) After bzr-pulling your latest changes and reviewing that source again, i noticed that you are using GRUB_ARG_OPTION_REPEATABLE for the new id option but you are not handling multiple ids (as far as i can see)= =2E 2) Why do you refuse to allow short options for all of the menuentry options? Any special reason? 3) Wouldn't it be a good chance to use my patch which uses an anonymous enum for indexing the options array?