From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S4LPS-0005MV-UL for mharc-grub-devel@gnu.org; Sun, 04 Mar 2012 19:04:14 -0500 Received: from eggs.gnu.org ([208.118.235.92]:33523) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4LPI-00054b-Hp for grub-devel@gnu.org; Sun, 04 Mar 2012 19:04:13 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4LPG-0006ZZ-Ov for grub-devel@gnu.org; Sun, 04 Mar 2012 19:04:04 -0500 Received: from mail-ee0-f41.google.com ([74.125.83.41]:39825) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4LPG-0006Y2-Fu for grub-devel@gnu.org; Sun, 04 Mar 2012 19:04:02 -0500 Received: by eeke53 with SMTP id e53so1328502eek.0 for ; Sun, 04 Mar 2012 16:04:00 -0800 (PST) Received-SPF: pass (google.com: domain of phcoder@gmail.com designates 10.213.8.148 as permitted sender) client-ip=10.213.8.148; Authentication-Results: mr.google.com; spf=pass (google.com: domain of phcoder@gmail.com designates 10.213.8.148 as permitted sender) smtp.mail=phcoder@gmail.com; dkim=pass header.i=phcoder@gmail.com Received: from mr.google.com ([10.213.8.148]) by 10.213.8.148 with SMTP id h20mr2859536ebh.21.1330905840506 (num_hops = 1); Sun, 04 Mar 2012 16:04:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=YFHN8xRs8XjWS553zx8VnNAjRWqxGSJHOUCyhm4Sh4w=; b=IsCT6106as5wTWT6NRpFZ6OKLhZh82HnUnjN0l343v7Q+1V59986VAoNst/U2Bcq6m GIzuf+fIo1UMcNhYwhlklmTefSncFPJGpVnAVIyNjQKPZV39TsiwXsLl32jaEMwM0nQa Q91wtUaoSq022lp0zHkZ/rZDsugKO3Uv9DuAlx4m3/O0f8HJgecfRy8V1wbXgfa/wppz oeOCP4yCevXdFbve/yLCf+RbsITAXCLOoBnL2XyCCgcZcu4QCkfgJuvbreVFXO8XOSvN sMe+O36B1DZSeTZCOpD4PYDcbtsqrhaaM3+1egxt1BTqpkThGmYTg1HFHa88RbIaqBcq 7eaQ== Received: by 10.213.8.148 with SMTP id h20mr2162244ebh.21.1330905840393; Sun, 04 Mar 2012 16:04:00 -0800 (PST) Received: from debian.x201.phnet (106-191.203-62.cust.bluewin.ch. [62.203.191.106]) by mx.google.com with ESMTPS id z47sm28740809een.5.2012.03.04.16.03.58 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 04 Mar 2012 16:03:59 -0800 (PST) Message-ID: <4F5402ED.6010707@gmail.com> Date: Mon, 05 Mar 2012 01:03:57 +0100 From: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 MIME-Version: 1.0 To: Andreas Vogel Subject: Re: Device instability, gettext and default References: <4F521E88.7070401@gmail.com> <4F53FFE7.2060407@anvo-it.de> In-Reply-To: <4F53FFE7.2060407@anvo-it.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 74.125.83.41 Cc: The development of GNU GRUB X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 00:04:13 -0000 On 05.03.2012 00:51, Andreas Vogel wrote: > Am 03.03.2012 14:37, schrieb Vladimir 'φ-coder/phcoder' Serbinenko: >> === modified file 'grub-core/commands/menuentry.c' >> --- grub-core/commands/menuentry.c 2012-02-26 16:28:05 +0000 >> +++ grub-core/commands/menuentry.c 2012-03-03 12:11:30 +0000 >> @@ -36,6 +36,8 @@ >> N_("Keyboard key to quickly boot this entry."), N_("KEYBOARD_KEY"), ARG_TYPE_STRING}, >> {"source", 4, 0, >> N_("Use STRING as menu entry body."), N_("STRING"), ARG_TYPE_STRING}, >> + {"id", 1, GRUB_ARG_OPTION_REPEATABLE, >> + N_("Menu entry identifier."), N_("STRING"), ARG_TYPE_STRING}, >> {0, 0, 0, 0, 0, 0} >> }; > 1) After bzr-pulling your latest changes and reviewing that source > again, i noticed that you are using GRUB_ARG_OPTION_REPEATABLE for the > new id option but you are not handling multiple ids (as far as i can see). It wasn't intentional. Fixed now. > 2) Why do you refuse to allow short options for all of the menuentry > options? Any special reason? Because it shares the space with options to menuentry. > 3) Wouldn't it be a good chance to use my patch which uses an anonymous > enum for indexing the options array? No. Thinking like this is a slippery slope. Such patches may also contain bugs (if you confuse 2 numbers). Your patch could be committed into experimental but not trunk. Life doesn't end at 2.00. > -- Regards Vladimir 'φ-coder/phcoder' Serbinenko