From: "Vladimir 'φ-coder/phcoder' Serbinenko" <phcoder@gmail.com>
To: The development of GNU GRUB <grub-devel@gnu.org>
Cc: Andreas Born <futur.andy@googlemail.com>
Subject: Re: Support for different hotkey action than execute
Date: Mon, 05 Mar 2012 02:37:54 +0100 [thread overview]
Message-ID: <4F5418F2.7000707@gmail.com> (raw)
In-Reply-To: <4F4ABB64.6020305@googlemail.com>
On 27.02.2012 00:08, Andreas Born wrote:
> Attached patch introduces a new environment variable hotkey_action. It
> can be set to select or execute, whereas the latter is the default. So
> the default behaviour doesn't change. With select set instead a menu
> entry is just selected and not executed/booted on hotkey press.
>
> This is for example useful for long menus to directly jump to some
> initial and afterwards select the desired entry without going through
> the whole menu. One still has to explicitly mark the menu entry to
> jump to with the hotkey attribute. This patch only allows to change
> the action to take on hotkey press.
>
> Not much code and most is inspired from grub_menu_get_timeout. Applies
> and works with r3991.
>
> Add support to the menu for changing the action on hotkey press:
> execute (default), select
>
> * grub-core/normal/menu.c (DEFAULT_HOTKEY_ACTION): New define.
This is a global change (affecting all menuentries) for a local goal
(have a jump hotkey for a menuentry). This has a drawback of making
simultaneous inclusion of two files with different behaviour
problematic. This should be implemented as a separate --jump-hotkey with
additional benefit of allowing both hotkey and jump hotkey at the same time.
> (run_menu): Handle hotkey_action.
> (grub_menu_get_hotkey_action): New function.
> * include/grub/menu.h (grub_menu_get_hotkey_action): New prototype.
> (grub_hotkey_action_type_t): New enum.
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel
--
Regards
Vladimir 'φ-coder/phcoder' Serbinenko
prev parent reply other threads:[~2012-03-05 1:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-26 23:08 Support for different hotkey action than execute Andreas Born
2012-03-04 21:13 ` Andreas Born
2012-03-04 21:26 ` Vladimir 'φ-coder/phcoder' Serbinenko
2012-03-05 1:37 ` Vladimir 'φ-coder/phcoder' Serbinenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5418F2.7000707@gmail.com \
--to=phcoder@gmail.com \
--cc=futur.andy@googlemail.com \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.