From mboxrd@z Thu Jan 1 00:00:00 1970 From: Masami Hiramatsu Date: Mon, 05 Mar 2012 02:55:33 +0000 Subject: Re: [PATCH] kprobes/x86: remove extern from function definition Message-Id: <4F542B25.6090901@hitachi.com> List-Id: References: <1330791128-3293-1-git-send-email-emilgoode@gmail.com> In-Reply-To: <1330791128-3293-1-git-send-email-emilgoode@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org (2012/03/04 1:12), Emil Goode wrote: > Functions with definition should not be declared extern. > > sparse warns: > arch/x86/kernel/kprobes.c:1489:13: warning: > function 'arch_unoptimize_kprobes' with external linkage > has definition > > Signed-off-by: Emil Goode Acked-by: Masami Hiramatsu Thank you! > --- > arch/x86/kernel/kprobes.c | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/arch/x86/kernel/kprobes.c b/arch/x86/kernel/kprobes.c > index 7da647d..f55c28e 100644 > --- a/arch/x86/kernel/kprobes.c > +++ b/arch/x86/kernel/kprobes.c > @@ -1486,8 +1486,8 @@ static void __kprobes setup_unoptimize_kprobe(struct text_poke_param *tprm, > * Recover original instructions and breakpoints from relative jumps. > * Caller must call with locking kprobe_mutex. > */ > -extern void arch_unoptimize_kprobes(struct list_head *oplist, > - struct list_head *done_list) > +void arch_unoptimize_kprobes(struct list_head *oplist, > + struct list_head *done_list) > { > struct optimized_kprobe *op, *tmp; > int c = 0; -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com