Re: [PATCH v4] ipv6: Fix problem with expired dst cache

[Gao feng <gaofeng@cn.fujitsu.com>]

于 2012年03月05日 13:05, David Miller 写道:
> From: Gao feng <gaofeng@cn.fujitsu.com>
> Date: Mon, 5 Mar 2012 11:53:48 +0800
> 
>> +		/* point to where the dst_entry copied from */
>> +		void			*from;
> 
> So instead of using a real type here, your just going to cast
> this thing to and from "struct dst_entry *" a thousand times?
> 
> That's terrible, there is zero value from using a void pointer
> here, it just makes the code look ugly.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Hi David
You are right.I will resend this patch changes void * to dst_entry *.

thanks for your patience.