All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Arend van Spriel" <arend@broadcom.com>
To: "Julian Calaby" <julian.calaby@gmail.com>
Cc: "John W. Linville" <linville@tuxdriver.com>,
	"Linux Wireless List" <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 4/7] brcm80211: fmac: initialize host interface drivers regardless result
Date: Mon, 5 Mar 2012 10:31:06 +0100	[thread overview]
Message-ID: <4F5487DA.2010805@broadcom.com> (raw)
In-Reply-To: <CAGRGNgXbkV-OkB5XG8+HqmmxG6f3RfgAkfnb_XxhXYU5+yN6Ug@mail.gmail.com>

On 03/04/2012 11:49 PM, Julian Calaby wrote:
> Hi Arend,
>
> On Sat, Mar 3, 2012 at 08:55, Arend van Spriel<arend@broadcom.com>  wrote:
>> The module init function of brcmfmac calls init functions for SDIO and
>> USB doing driver registration. This patch removes terminating the module
>> init when a driver registration for one host interface fails.
>
> Would it be better to fail the module load if *none* of them succeed -
> there's probably no point in having the module loaded if it's not
> actually hooked up to anything.
>

Thanks, Julian

However, the next patch in this series would undo the init code 
behaviour you are proposing. The brcmf_sdio_init() already logs the 
failed driver registration. I will add the same to brcmf_usb_init() in a 
separate patch. Is that ok with you?

Gr. AvS



  reply	other threads:[~2012-03-05  9:31 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 21:55 [PATCH 0/7] firmware request changed for udev and other cleanup Arend van Spriel
2012-03-02 21:55 ` [PATCH 1/7] brcm80211: fmac: remove unnecessary NULL pointer check Arend van Spriel
2012-03-02 21:55 ` [PATCH 2/7] brcm80211: fmac: remove brcmf_usb_attrib structure Arend van Spriel
2012-03-02 21:55 ` [PATCH 3/7] brcm80211: fmac: use counters in brcmf_bus structure Arend van Spriel
2012-03-02 21:55 ` [PATCH 4/7] brcm80211: fmac: initialize host interface drivers regardless result Arend van Spriel
2012-03-04 22:49   ` Julian Calaby
2012-03-05  9:31     ` Arend van Spriel [this message]
2012-03-05 11:44       ` Julian Calaby
2012-03-02 21:55 ` [PATCH 5/7] brcm80211: fmac: remove firmware requests from init_module syscall Arend van Spriel
2012-03-02 21:55 ` [PATCH 6/7] brcm80211: smac: " Arend van Spriel
2012-03-02 21:55 ` [PATCH 7/7] brcm80211: smac: cleanup couple of debug output statements Arend van Spriel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5487DA.2010805@broadcom.com \
    --to=arend@broadcom.com \
    --cc=julian.calaby@gmail.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.