From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof
Date: Mon, 05 Mar 2012 14:23:13 +0100 [thread overview]
Message-ID: <4F54BE41.7040409@suse.de> (raw)
In-Reply-To: <1330928551-6452-1-git-send-email-sw@weilnetz.de>
Am 05.03.2012 07:22, schrieb Stefan Weil:
> The macro offsetof is defined in stddef.h. It is conforming to
> the standards C89, C99 and POSIX.1-2001 (see man page), so it
> is a sufficiently old standard.
>
> Therefore chances are very high that QEMU never needs a local
> definition of this macro.
>
> osdep.h already includes stddef.h, so this patch simply removes
> the unneeded code from the files configure and osdep.h.
>
> If we ever need the local definition again, it should be added
> to compiler.h (the macro is usually provided with the compiler,
> it is not OS specific).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Did you check when this was introduced and whether the commit message
gave any explanation why?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas Färber" <afaerber@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-trivial <qemu-trivial@nongnu.org>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] osdep: Remove local definition of macro offsetof
Date: Mon, 05 Mar 2012 14:23:13 +0100 [thread overview]
Message-ID: <4F54BE41.7040409@suse.de> (raw)
In-Reply-To: <1330928551-6452-1-git-send-email-sw@weilnetz.de>
Am 05.03.2012 07:22, schrieb Stefan Weil:
> The macro offsetof is defined in stddef.h. It is conforming to
> the standards C89, C99 and POSIX.1-2001 (see man page), so it
> is a sufficiently old standard.
>
> Therefore chances are very high that QEMU never needs a local
> definition of this macro.
>
> osdep.h already includes stddef.h, so this patch simply removes
> the unneeded code from the files configure and osdep.h.
>
> If we ever need the local definition again, it should be added
> to compiler.h (the macro is usually provided with the compiler,
> it is not OS specific).
>
> Signed-off-by: Stefan Weil <sw@weilnetz.de>
Did you check when this was introduced and whether the commit message
gave any explanation why?
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-05 13:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 6:22 [Qemu-trivial] [PATCH] osdep: Remove local definition of macro offsetof Stefan Weil
2012-03-05 6:22 ` [Qemu-devel] " Stefan Weil
2012-03-05 13:23 ` Andreas Färber [this message]
2012-03-05 13:23 ` Andreas Färber
2012-03-05 13:49 ` [Qemu-trivial] " Peter Maydell
2012-03-05 13:49 ` Peter Maydell
2012-03-05 17:29 ` [Qemu-trivial] " Stefan Weil
2012-03-05 17:29 ` Stefan Weil
2012-03-05 16:53 ` [Qemu-trivial] " Stefan Hajnoczi
2012-03-05 16:53 ` [Qemu-devel] " Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F54BE41.7040409@suse.de \
--to=afaerber@suse.de \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.