From mboxrd@z Thu Jan 1 00:00:00 1970 From: Igor Mitsyanko Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Date: Mon, 05 Mar 2012 18:37:23 +0400 Message-ID: <4F54CFA3.6080400@samsung.com> References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F54C1C0.6030803@samsung.com> <4F54CA04.4070804@redhat.com> Reply-To: i.mitsyanko@samsung.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7BIT Cc: Peter Maydell , =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= , Anthony Liguori , quintela@redhat.com, Developers qemu-devel , KVM devel mailing list , Dmitry Solodkiy To: Avi Kivity Return-path: Received: from mailout2.w1.samsung.com ([210.118.77.12]:45242 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932348Ab2CEOh3 (ORCPT ); Mon, 5 Mar 2012 09:37:29 -0500 Received: from euspt1 (mailout2.w1.samsung.com [210.118.77.12]) by mailout2.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0M0F000DJ1YFZK@mailout2.w1.samsung.com> for kvm@vger.kernel.org; Mon, 05 Mar 2012 14:37:27 +0000 (GMT) Received: from [106.109.8.162] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M0F00B111YEOB@spt1.w1.samsung.com> for kvm@vger.kernel.org; Mon, 05 Mar 2012 14:37:27 +0000 (GMT) In-reply-to: <4F54CA04.4070804@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 03/05/2012 06:13 PM, Avi Kivity wrote: > On 03/05/2012 03:38 PM, Igor Mitsyanko wrote: >>> Short summary: >>> * switch wp groups to bitfield rather than int array >>> * convert sd.c to use memory_region_init_ram() to allocate the wp >>> groups >>> (being careful to use memory_region_set_dirty() when we touch them) >>> * we don't need variable-length fields for sd.c any more >>> * rest of the vmstate conversion is straightforward >>> >> >> OK, it turned out to be not so simple, we can't use memory API in sd.c >> because TARGET_PHYS_ADDR_BITS value (and, consequently, >> target_phys_addr_t) is not defined for common objects. >> > > Well, can't you make sd.c target dependent? It's not so nice, but it > does solve the problem. > OK, but it will turn qemu from it's "long term path to suppress *all* target specific code" :) -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:38663) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4Z30-0003NA-5g for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:38:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4Z2Z-0007sL-Rk for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:37:57 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:44802) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4Z2Z-0007rt-Lu for qemu-devel@nongnu.org; Mon, 05 Mar 2012 09:37:31 -0500 Received: from euspt1 (mailout1.w1.samsung.com [210.118.77.11]) by mailout1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTP id <0M0F00BHY1YDOY@mailout1.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 05 Mar 2012 14:37:25 +0000 (GMT) Received: from [106.109.8.162] by spt1.w1.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0M0F00B111YEOB@spt1.w1.samsung.com> for qemu-devel@nongnu.org; Mon, 05 Mar 2012 14:37:27 +0000 (GMT) Date: Mon, 05 Mar 2012 18:37:23 +0400 From: Igor Mitsyanko In-reply-to: <4F54CA04.4070804@redhat.com> Message-id: <4F54CFA3.6080400@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7BIT References: <87ehuhrpel.fsf@elfo.elfo> <4F272A92.2010609@suse.de> <4F272D8C.8020608@codemonkey.ws> <4F27E98E.2080501@suse.de> <4F54C1C0.6030803@samsung.com> <4F54CA04.4070804@redhat.com> Subject: Re: [Qemu-devel] KVM call agenda for tuesday 31 Reply-To: i.mitsyanko@samsung.com List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Peter Maydell , KVM devel mailing list , quintela@redhat.com, Developers qemu-devel , Dmitry Solodkiy , Anthony Liguori , =?UTF-8?B?QW5kcmVhcyBGw6RyYg==?= =?UTF-8?B?ZXI=?= On 03/05/2012 06:13 PM, Avi Kivity wrote: > On 03/05/2012 03:38 PM, Igor Mitsyanko wrote: >>> Short summary: >>> * switch wp groups to bitfield rather than int array >>> * convert sd.c to use memory_region_init_ram() to allocate the wp >>> groups >>> (being careful to use memory_region_set_dirty() when we touch them) >>> * we don't need variable-length fields for sd.c any more >>> * rest of the vmstate conversion is straightforward >>> >> >> OK, it turned out to be not so simple, we can't use memory API in sd.c >> because TARGET_PHYS_ADDR_BITS value (and, consequently, >> target_phys_addr_t) is not defined for common objects. >> > > Well, can't you make sd.c target dependent? It's not so nice, but it > does solve the problem. > OK, but it will turn qemu from it's "long term path to suppress *all* target specific code" :) -- Mitsyanko Igor ASWG, Moscow R&D center, Samsung Electronics email: i.mitsyanko@samsung.com