From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1S4a4l-00070y-WF for mharc-grub-devel@gnu.org; Mon, 05 Mar 2012 10:43:52 -0500 Received: from eggs.gnu.org ([208.118.235.92]:50858) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4a4V-0006dA-OB for grub-devel@gnu.org; Mon, 05 Mar 2012 10:43:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4a4O-0006Pp-LK for grub-devel@gnu.org; Mon, 05 Mar 2012 10:43:35 -0500 Received: from wp191.webpack.hosteurope.de ([80.237.132.198]:51332) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4a4O-0006PT-DC for grub-devel@gnu.org; Mon, 05 Mar 2012 10:43:28 -0500 Received: from p4ff1551c.dip.t-dialin.net ([79.241.85.28] helo=neptun.omega.ssw.de); authenticated by wp191.webpack.hosteurope.de running ExIM with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) id 1S4a4M-0005i5-4I; Mon, 05 Mar 2012 16:43:26 +0100 Received: from localhost (localhost [127.0.0.1]) by neptun.omega.ssw.de (Postfix) with ESMTP id 540AEE180A8; Mon, 5 Mar 2012 16:43:25 +0100 (CET) X-Virus-Scanned: amavisd-new at omega.ssw.de Received: from neptun.omega.ssw.de ([127.0.0.1]) by localhost (neptun.omega.ssw.de [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id kcsnPlNaXDUu; Mon, 5 Mar 2012 16:43:14 +0100 (CET) Received: from [192.168.2.43] (p640.fritz.box [192.168.2.43]) (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by neptun.omega.ssw.de (Postfix) with ESMTP id 324BAE180A7; Mon, 5 Mar 2012 16:43:14 +0100 (CET) Message-ID: <4F54DF19.7000804@anvo-it.de> Date: Mon, 05 Mar 2012 16:43:21 +0100 From: Andreas Vogel User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:10.0.2) Gecko/20120216 Thunderbird/10.0.2 MIME-Version: 1.0 To: =?UTF-8?B?VmxhZGltaXIgJ8+GLWNvZGVyL3BoY29kZXInIFNlcmJpbmVua28=?= Subject: Re: Ideas for the future References: <4F541349.7070704@anvo-it.de> <4F541723.6030105@gmail.com> <4F54A094.1000000@anvo-it.de> <4F54B78B.9010707@gmail.com> In-Reply-To: <4F54B78B.9010707@gmail.com> X-Enigmail-Version: 1.3.5 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-bounce-key: webpack.hosteurope.de; andreas.vogel@anvo-it.de; 1330962208; 12c00dcc; X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.237.132.198 Cc: The development of GNU GRUB , Colin Watson X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list Reply-To: The development of GNU GRUB List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 05 Mar 2012 15:43:50 -0000 Am 05.03.2012 13:54, schrieb Vladimir '=CF=86-coder/phcoder' Serbinenko: >> option with an optional argument. By this we would have had what you >> preference and my way too. Regarding optional arguments the option >> handling in GRUB is actually broken by design, so this is, >> unfortunately, not an option. > When i implemented my patches, i wanted to use both ways: a command lin= e > Again it's unfortunate that noone noticed it when it was committed and > now we're stuck with it. You should think about that again. GRUB is broken regarding that and it should be fixed anyway. Right now it seems that there is only one command which uses GRUB_ARG_OPTION_OPTIONAL so maybe it's one of the last chances to have a cheap fix. The (only!?) place where an optional option is used is the --set option for the search command. The manual entry for search states: search [--file|--label|--fs-uuid] [--set [var]] [--no-floppy] name The description is wrong. For --set it's only possible to omit "var" iff another option is following the --set option. OK: search --file --set --nofloppy /boot/grub/grub.cfg OK: search --file --set -- /boot/grub/grub.cfg ERROR: search --file --set /boot/grub/grub.cfg It's either needed to correct the manual or to fix the code. If it's decided that the code cannot be fixed (for whatever reasons) the use of optional option arguments should be strongly discouraged or even forbidden then. Andreas