All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Graf <agraf@suse.de>
To: Stefan Weil <sw@weilnetz.de>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 5/6] cache-utils: Change data type of parameters for flush_icache_range
Date: Mon, 05 Mar 2012 19:57:54 +0100	[thread overview]
Message-ID: <4F550CB2.4040201@suse.de> (raw)
In-Reply-To: <1330727407-24014-6-git-send-email-sw@weilnetz.de>

On 03/02/2012 11:30 PM, Stefan Weil wrote:
> The TCG targets i386 and tci needed a change of the function
> prototype for w64.
>
> This change is currently not needed here, but it can be applied
> to avoid code differences.
>
> Cc: Alexander Graf<agraf@suse.de>
> Signed-off-by: Stefan Weil<sw@weilnetz.de>
> ---
>   cache-utils.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/cache-utils.h b/cache-utils.h
> index 0b65907..04a6e2e 100644
> --- a/cache-utils.h
> +++ b/cache-utils.h
> @@ -12,7 +12,7 @@ extern struct qemu_cache_conf qemu_cache_conf;
>   void qemu_cache_utils_init(char **envp);
>
>   /* mildly adjusted code from tcg-dyngen.c */
> -static inline void flush_icache_range(unsigned long start, unsigned long stop)
> +static inline void flush_icache_range(uintptr_t start, uintptr_t stop)

Ugh, this causes compilation breakage:

CC cache-utils.o
In file included from cache-utils.c:1:
cache-utils.h:15: error: expected ‘)’ before ‘start’
make: *** [cache-utils.o] Error 1

because cache-utils.c doesn't include anything that would define 
uintptr_t. Any idea how to fix this?


Alex

  parent reply	other threads:[~2012-03-05 18:58 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 22:30 [Qemu-devel] [PATCH 0/6] w64: Improve compilation with MinGW-w64 Stefan Weil
2012-03-02 22:30 ` [Qemu-devel] [PATCH 1/6] w64: Fix size of ram_addr_t Stefan Weil
2012-03-02 22:30 ` [Qemu-devel] [PATCH 2/6] tcg: Rearrange definitions and include statements Stefan Weil
2012-03-02 22:30 ` [Qemu-devel] [PATCH 3/6] w64: Fix data type of parameters for flush_icache_range Stefan Weil
2012-03-02 22:30 ` [Qemu-devel] [PATCH 4/6] w64: Change " Stefan Weil
2012-03-02 22:30 ` [Qemu-devel] [PATCH 5/6] cache-utils: " Stefan Weil
2012-03-02 22:39   ` Alexander Graf
2012-03-05 18:57   ` Alexander Graf [this message]
2012-03-05 20:07     ` Stefan Weil
2012-03-05 20:15       ` Alexander Graf
2012-03-05 20:15         ` [Qemu-devel] [PATCH] cache-utils: Add missing include file for uintptr_t Stefan Weil
2012-03-06 23:51           ` Alexander Graf
2012-03-11 16:08           ` Blue Swirl
2012-03-02 22:30 ` [Qemu-devel] [PATCH 6/6] w64: fix type casts when calling flush_icache_range Stefan Weil
2012-03-04 11:27 ` [Qemu-devel] [PATCH 0/6] w64: Improve compilation with MinGW-w64 Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F550CB2.4040201@suse.de \
    --to=agraf@suse.de \
    --cc=qemu-devel@nongnu.org \
    --cc=sw@weilnetz.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.