From: "Andreas Färber" <afaerber@suse.de>
To: Meador Inge <meadori@codesourcery.com>
Cc: "qemu-ppc@nongnu.org" <qemu-ppc@nongnu.org>,
qemu-devel@nongnu.org, agraf@suse.de
Subject: Re: [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT
Date: Mon, 05 Mar 2012 20:53:28 +0100 [thread overview]
Message-ID: <4F5519B8.9050903@suse.de> (raw)
In-Reply-To: <4F54F283.6020207@codesourcery.com>
Am 05.03.2012 18:06, schrieb Meador Inge:
> On 02/23/2012 07:44 AM, Meador Inge wrote:
>
>> 'POWERPC_INSNS2_DEFAULT' was defined incorrectly which was causing the
>> opcode table creation code to erroneously register 'eieio' and 'mbar'
>> for the "default" processor:
>>
>> ** ERROR: opcode 1a already assigned in opcode table 16
>> *** ERROR: unable to insert opcode [1f-16-1a]
>> *** ERROR initializing PowerPC instruction 0x1f 0x16 0x1a
>>
>> Signed-off-by: Meador Inge <meadori@codesourcery.com>
>
> Ping.
Cc'ing qemu-ppc.
What's the test case (command line) that breaks? Don't all machines use
different default CPUs? I would rather drop these ..._DEFAULT defines in
favor of using a real CPU model - but maybe I'm misunderstanding something?
Andreas
>
>> ---
>> target-ppc/translate_init.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c
>> index 6253076..6cb5fad 100644
>> --- a/target-ppc/translate_init.c
>> +++ b/target-ppc/translate_init.c
>> @@ -6713,7 +6713,7 @@ static void init_proc_620 (CPUPPCState *env)
>> #if defined (TARGET_PPC64) && 0 // XXX: TODO
>> #define CPU_POWERPC_DEFAULT CPU_POWERPC_PPC64
>> #define POWERPC_INSNS_DEFAULT POWERPC_INSNS_PPC64
>> -#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS_PPC64
>> +#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS2_PPC64
>> #define POWERPC_MSRM_DEFAULT POWERPC_MSRM_PPC64
>> #define POWERPC_MMU_DEFAULT POWERPC_MMU_PPC64
>> #define POWERPC_EXCP_DEFAULT POWERPC_EXCP_PPC64
>> @@ -6725,7 +6725,7 @@ static void init_proc_620 (CPUPPCState *env)
>> #else
>> #define CPU_POWERPC_DEFAULT CPU_POWERPC_PPC32
>> #define POWERPC_INSNS_DEFAULT POWERPC_INSNS_PPC32
>> -#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS_PPC32
>> +#define POWERPC_INSNS2_DEFAULT POWERPC_INSNS2_PPC32
>> #define POWERPC_MSRM_DEFAULT POWERPC_MSRM_PPC32
>> #define POWERPC_MMU_DEFAULT POWERPC_MMU_PPC32
>> #define POWERPC_EXCP_DEFAULT POWERPC_EXCP_PPC32
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
next prev parent reply other threads:[~2012-03-05 19:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-23 13:44 [Qemu-devel] [PATCH v1 1/1] ppc: Correctly define POWERPC_INSNS2_DEFAULT Meador Inge
2012-03-05 17:06 ` Meador Inge
2012-03-05 19:53 ` Andreas Färber [this message]
2012-03-05 20:26 ` Meador Inge
2012-03-12 19:20 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5519B8.9050903@suse.de \
--to=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=meadori@codesourcery.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.