From: Fabio M. Di Nitto <fdinitto@redhat.com>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [Patch] GFS2: Add gfs2_lockgather script and man page
Date: Tue, 06 Mar 2012 05:08:54 +0100 [thread overview]
Message-ID: <4F558DD6.5060605@redhat.com> (raw)
In-Reply-To: <1330972478.2699.112.camel@menhir>
On 03/05/2012 07:34 PM, Steven Whitehouse wrote:
> Hi,
>
> On Mon, 2012-03-05 at 19:27 +0100, Fabio M. Di Nitto wrote:
>> On 03/05/2012 06:51 PM, Adam Drew wrote:
>>> This is a backport of the gfs2_lockgather script and manpage from gfs2_utils upstream.
>>
>> I have to NACK this backport for now.
>>
>> I already explain to Adam what needs changing.
>>
>> Fabio
>>
>
> What is the issue?
Forgot to mention in the previous email:
since this is a long time (tar/ssh/scp..) running script, it needs to
handle trap of signals and locking differently or if a user hits ctrl+c
or the script is killed for whatever reason, it doesn't clean after
itself. Leaking disk space and leaving the lock file around that would
block the next run.
I didn't check all the paths it uses, but an update to selinux policies
might be necessary too.
Fabio
prev parent reply other threads:[~2012-03-06 4:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 17:51 [Cluster-devel] [Patch] GFS2: Add gfs2_lockgather script and man page Adam Drew
2012-03-05 18:04 ` Steven Whitehouse
2012-03-05 18:27 ` Fabio M. Di Nitto
2012-03-05 18:34 ` Steven Whitehouse
2012-03-06 3:54 ` Fabio M. Di Nitto
2012-03-06 4:08 ` Fabio M. Di Nitto [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F558DD6.5060605@redhat.com \
--to=fdinitto@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.