From: "H. Peter Anvin" <hpa@zytor.com>
To: NeilBrown <neilb@suse.de>
Cc: Steven Haigh <netwiz@crc.id.au>,
John Robinson <john.robinson@anonymous.org.uk>,
linux-raid@vger.kernel.org
Subject: Re: mdadm: sending ioctl 1261 to a partition!
Date: Mon, 05 Mar 2012 21:29:59 -0800 [thread overview]
Message-ID: <4F55A0D7.4040908@zytor.com> (raw)
In-Reply-To: <20120306132701.1b9600f4@notabene.brown>
On 03/05/2012 06:27 PM, NeilBrown wrote:
>
> So it is still called fsync_bdev and invalidate_bdev as long as the
> ioctl function for the underlying disk returns -EINVAL or -ENOTTY.
>
> The function that shows that warning is scsi_verify_blk_ioctl in
> block/scsi_ioctl.c The worst it can do is return -ENOTTY, and that
> is safe.
>
> So the warning is bogus, the code still works.
>
We should whitelist ioctls if they are legitimately used and harmless.
Do we have a specific list?
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
next prev parent reply other threads:[~2012-03-06 5:29 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 13:03 mdadm: sending ioctl 1261 to a partition! Steven Haigh
2012-03-05 14:52 ` John Robinson
2012-03-05 18:53 ` Steven Haigh
2012-03-05 20:01 ` NeilBrown
2012-03-06 2:00 ` Steven Haigh
2012-03-06 2:27 ` NeilBrown
2012-03-06 2:38 ` Steven Haigh
2012-03-06 5:29 ` H. Peter Anvin [this message]
2012-03-08 0:04 ` NeilBrown
2012-03-08 10:54 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F55A0D7.4040908@zytor.com \
--to=hpa@zytor.com \
--cc=john.robinson@anonymous.org.uk \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=netwiz@crc.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.