From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jiri Slaby Date: Tue, 06 Mar 2012 14:09:39 +0000 Subject: Re: [patch v2] tty: cyclades: TIOCSERGETLSR should should store to a uint Message-Id: <4F561AA3.6050600@suse.cz> List-Id: References: <20120305180711.GB26880@elgon.mountain> In-Reply-To: <20120305180711.GB26880@elgon.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jiri Slaby On 03/05/2012 07:07 PM, Dan Carpenter wrote: > TIOCSERGETLSR should be saved in a uint so the cast here to unsigned > long is a bug. > > Reported-by: Jiri Slaby > Signed-off-by: Dan Carpenter ACK. Thanks. > --- > v2: completely different from v1. > > diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c > index c9bf779..5575fee 100644 > --- a/drivers/tty/cyclades.c > +++ b/drivers/tty/cyclades.c > @@ -2413,7 +2413,7 @@ static int get_lsr_info(struct cyclades_port *info, unsigned int __user *value) > /* Not supported yet */ > return -EINVAL; > } > - return put_user(result, (unsigned long __user *)value); > + return put_user(result, value); > } > > static int cy_tiocmget(struct tty_struct *tty) -- js suse labs From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759264Ab2CFOJp (ORCPT ); Tue, 6 Mar 2012 09:09:45 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:33662 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758591Ab2CFOJn (ORCPT ); Tue, 6 Mar 2012 09:09:43 -0500 Authentication-Results: mr.google.com; spf=pass (google.com: domain of jirislaby@gmail.com designates 10.213.104.143 as permitted sender) smtp.mail=jirislaby@gmail.com; dkim=pass header.i=jirislaby@gmail.com Message-ID: <4F561AA3.6050600@suse.cz> Date: Tue, 06 Mar 2012 15:09:39 +0100 From: Jiri Slaby User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120222 Thunderbird/11.0 MIME-Version: 1.0 To: Dan Carpenter CC: Greg Kroah-Hartman , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, Jiri Slaby Subject: Re: [patch v2] tty: cyclades: TIOCSERGETLSR should should store to a uint References: <20120305180711.GB26880@elgon.mountain> In-Reply-To: <20120305180711.GB26880@elgon.mountain> X-Enigmail-Version: 1.4 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/2012 07:07 PM, Dan Carpenter wrote: > TIOCSERGETLSR should be saved in a uint so the cast here to unsigned > long is a bug. > > Reported-by: Jiri Slaby > Signed-off-by: Dan Carpenter ACK. Thanks. > --- > v2: completely different from v1. > > diff --git a/drivers/tty/cyclades.c b/drivers/tty/cyclades.c > index c9bf779..5575fee 100644 > --- a/drivers/tty/cyclades.c > +++ b/drivers/tty/cyclades.c > @@ -2413,7 +2413,7 @@ static int get_lsr_info(struct cyclades_port *info, unsigned int __user *value) > /* Not supported yet */ > return -EINVAL; > } > - return put_user(result, (unsigned long __user *)value); > + return put_user(result, value); > } > > static int cy_tiocmget(struct tty_struct *tty) -- js suse labs