From: Paolo Bonzini <pbonzini@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: amit.shah@redhat.com, uobergfe@redhat.com, owasserm@redhat.com,
qemu-devel@nongnu.org, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features
Date: Tue, 06 Mar 2012 15:59:53 +0100 [thread overview]
Message-ID: <4F562669.7060703@redhat.com> (raw)
In-Reply-To: <20120306145529.GF12096@redhat.com>
Il 06/03/2012 15:55, Michael S. Tsirkin ha scritto:
> > It is not a problem if the destination does not have
> > VIRTIO_BALLOON_F_MUST_TELL_HOST. In that case, the guest
> > will simply do useless virtqueue traffic, but the destination
> > does not have a problem.
> > (In fact, it _is_ a problem if the destination has
> > VIRTIO_BALLOON_F_MUST_TELL_HOST but the source does not.
> > The feature bit should have been backwards! Luckily,
> > our implementation is free from this problem).
> >
> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
>
> Can't we just add a flag to control this feature?
I think the sane thing here would be to remove it from the spec.
Paolo
next prev parent reply other threads:[~2012-03-06 15:00 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 12:22 [Qemu-devel] [PATCH 0/3] Make virtio_load permissive when possible Paolo Bonzini
2012-03-06 12:22 ` [Qemu-devel] [PATCH 1/3] virtio: let devices be permissive on enabled features Paolo Bonzini
2012-03-06 13:33 ` Michael S. Tsirkin
2012-03-06 13:57 ` Paolo Bonzini
2012-03-06 14:22 ` Orit Wasserman
2012-03-06 12:22 ` [Qemu-devel] [PATCH 2/3] virtio-balloon: note optional features Paolo Bonzini
2012-03-06 14:55 ` Michael S. Tsirkin
2012-03-06 14:59 ` Paolo Bonzini [this message]
2012-03-06 15:08 ` Michael S. Tsirkin
2012-03-06 15:13 ` Paolo Bonzini
2012-03-06 12:22 ` [Qemu-devel] [PATCH 3/3] virtio-blk: " Paolo Bonzini
2012-03-06 14:53 ` Michael S. Tsirkin
2012-03-06 15:58 ` Paolo Bonzini
2012-03-06 17:03 ` Anthony Liguori
2012-03-06 17:12 ` Paolo Bonzini
2012-03-06 17:15 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F562669.7060703@redhat.com \
--to=pbonzini@redhat.com \
--cc=amit.shah@redhat.com \
--cc=armbru@redhat.com \
--cc=mst@redhat.com \
--cc=owasserm@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=uobergfe@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.