All of lore.kernel.org
 help / color / mirror / Atom feed
From: Mike Christie <michaelc@cs.wisc.edu>
To: Hannes Reinecke <hare@suse.de>
Cc: "Michael Tokarev" <mjt@tls.msk.ru>,
	"Andreas Färber" <afaerber@suse.de>,
	"ronnie sahlberg" <ronniesahlberg@gmail.com>,
	qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] QEMU desired libiscsi.so clashes with libiscsi.so from iscsi-initiator-utils
Date: Tue, 06 Mar 2012 14:13:48 -0600	[thread overview]
Message-ID: <4F566FFC.4070407@cs.wisc.edu> (raw)
In-Reply-To: <4F566C51.3080301@cs.wisc.edu>

On 03/06/2012 01:58 PM, Mike Christie wrote:
> On 03/06/2012 06:19 AM, Hannes Reinecke wrote:
>> On 03/06/2012 12:06 PM, ronnie sahlberg wrote:
>>> Sorry about this.
>>>
>>> First, libiscsi is a really good name for a general purpose
>>> multiplatform library, like libiscsi.
>>> Second,  a generic name like this is a horribly poor idea for a single
>>> distribution/ single use / obscure private library.
>>>
>> Yes.
>>
>>>
>>> I want to solve a problem  to make it available on all platforms.
>>> I dont like to chose a suboptimal name for this reason,  but I thought
>>> I had no choice.
>>>
>> Fully agreed. I'm perfectly fine with libiscsi ...
>>
>>>
>>> I am not really excited with the concept of "obscure single use
>>> private library polluting the namespace like this" but what are my
>>> options ?
>>> I can live with renaming my library if that is what it takes.
>>>
>> IMO the only sane option here is to have a separate package,
>> containing libiscsi _only_.
>>
>> It can be a sub-package of existing iscsi-related things, ie
>> contained within the existing open-iscsi _source_ repository.
>>
>> But having is packaged _together_ with another rpm is really bad.
>> Plus it makes updating a nightmare.
>>
>> So, Mike, what about having it as a sub-package to open-iscsi?
>> I'm all for it, especially as some partners are already asking for
>> it ...
>>
> 
> Not sure what we are talking about. Are you talking about the libiscsi
> that ships in fedora/rhel? That comes in the iscsi-initiator-utils-devel
> rpm already. It should not get installed with just the
> iscsi-initiator-utils rpm.
> 
> That lib really should only be used by anaconda. That lib is not a good
> general purpose lib. It is kinda awkward. Some of the iscsi concepts are
> mixed up. My preference is that only anaconda ever uses that lib,
> because I am not supporting it upstream. It is not merged upstream for
> example. The upstream iscsi tools do not use it (anaconda people
> actually wrote it so it works for them, but it does not work for
> iscsiadm for example). I only support it for rhel/fedora for anaconda use.


Oh yeah, if the libiscsi from iscsi-initiator-utils-devel is causing
naming conflicts then I am fine with renaming that to something else if
that fixes the issue.

  reply	other threads:[~2012-03-06 20:14 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-13 13:24 [Qemu-devel] QEMU desired libiscsi.so clashes with libiscsi.so from iscsi-initiator-utils Daniel P. Berrange
2012-03-03  6:43 ` ronnie sahlberg
2012-03-03 11:15   ` Andreas Färber
2012-03-03 11:54     ` Michael Tokarev
2012-03-06 10:07       ` Daniel P. Berrange
2012-03-06 10:38         ` Michael Tokarev
2012-03-06 11:06           ` ronnie sahlberg
2012-03-06 11:15             ` Daniel P. Berrange
2012-03-06 14:10               ` Michael Tokarev
2012-03-06 12:19             ` Hannes Reinecke
2012-03-06 19:58               ` Mike Christie
2012-03-06 20:13                 ` Mike Christie [this message]
2012-03-07  1:51                   ` ronnie sahlberg
2012-03-07  2:30                     ` Mike Christie
2012-03-06 10:02   ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F566FFC.4070407@cs.wisc.edu \
    --to=michaelc@cs.wisc.edu \
    --cc=afaerber@suse.de \
    --cc=hare@suse.de \
    --cc=mjt@tls.msk.ru \
    --cc=qemu-devel@nongnu.org \
    --cc=ronniesahlberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.