From mboxrd@z Thu Jan 1 00:00:00 1970 From: swarren@wwwdotorg.org (Stephen Warren) Date: Tue, 06 Mar 2012 14:21:43 -0700 Subject: [PATCH] pinctrl: split pincontrol states into its own header In-Reply-To: <1331068552-16988-1-git-send-email-linus.walleij@stericsson.com> References: <1331068552-16988-1-git-send-email-linus.walleij@stericsson.com> Message-ID: <4F567FE7.4020507@wwwdotorg.org> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 03/06/2012 02:15 PM, Linus Walleij wrote: > From: Linus Walleij > > Move the pin control state defines into its own header file, > since it is used both by machine.h which is facing the platform > and by consumer.h which is facing the drivers, and pinctrl.h > which is pinctrl-driver internal, let's not have each and every > .h file include all others, then isolation is moot. > > Signed-off-by: Linus Walleij Sure. I'm not quite sure how many (or how many standardized) states we expect to have such that it warrants 'pinctrl-state.h' vs. say 'pinctrl-common.h', but it's probably fine. Acked-by: Stephen Warren From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756107Ab2CFVVt (ORCPT ); Tue, 6 Mar 2012 16:21:49 -0500 Received: from avon.wwwdotorg.org ([70.85.31.133]:49946 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754910Ab2CFVVs (ORCPT ); Tue, 6 Mar 2012 16:21:48 -0500 Message-ID: <4F567FE7.4020507@wwwdotorg.org> Date: Tue, 06 Mar 2012 14:21:43 -0700 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.23) Gecko/20110921 Thunderbird/3.1.15 MIME-Version: 1.0 To: Linus Walleij CC: "linux-kernel@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , Stephen Warren , Shawn Guo , Thomas Abraham , Dong Aisheng , Rajendra Nayak , Haojian Zhuang , Linus Walleij Subject: Re: [PATCH] pinctrl: split pincontrol states into its own header References: <1331068552-16988-1-git-send-email-linus.walleij@stericsson.com> In-Reply-To: <1331068552-16988-1-git-send-email-linus.walleij@stericsson.com> X-Enigmail-Version: 1.1.2 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/06/2012 02:15 PM, Linus Walleij wrote: > From: Linus Walleij > > Move the pin control state defines into its own header file, > since it is used both by machine.h which is facing the platform > and by consumer.h which is facing the drivers, and pinctrl.h > which is pinctrl-driver internal, let's not have each and every > .h file include all others, then isolation is moot. > > Signed-off-by: Linus Walleij Sure. I'm not quite sure how many (or how many standardized) states we expect to have such that it warrants 'pinctrl-state.h' vs. say 'pinctrl-common.h', but it's probably fine. Acked-by: Stephen Warren