From: Prabhakar Kushwaha <prabhakar@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/4] doc: Add documentation for mpc85xx debugger support
Date: Wed, 7 Mar 2012 09:02:47 +0530 [thread overview]
Message-ID: <4F56D6DF.3070701@freescale.com> (raw)
In-Reply-To: <20120306143923.69215202D7D@gemini.denx.de>
Hi Wolfgang,
Thanks for reviewing this patch.
Please find my response in-lined
On Tuesday 06 March 2012 08:09 PM, Wolfgang Denk wrote:
> Dear Prabhakar Kushwaha,
>
> In message<1329296027-28471-1-git-send-email-prabhakar@freescale.com> you wrote:
>> This describes requirement of e500 and e500v2 processor to support any
>> debugger. it also provide an insight of switch used and defined.
>>
>> Signed-off-by: Radu Lazarescu<radu.lazarescu@freescale.com>
>> Signed-off-by: Prabhakar Kushwaha<prabhakar@freescale.com>
>> ---
>> Applies on http://git.denx.de/u-boot.git branch master
>>
>> doc/README.mpc85xx_debugger | 44 +++++++++++++++++++++++++++++++++++++++++++
>> 1 files changed, 44 insertions(+), 0 deletions(-)
>> create mode 100644 doc/README.mpc85xx_debugger
> This document contains a number of typos and othe rerrors, mixed with
> inconsitent indentation (some lines use TABs, others use spaces).
>
> I suggest you clean it up and have it reviewed by a native speaker
> before resubmitting.
I will take care of your review-comments and will have first review at
native level before floating it again.
> Regarding the split into 4 separate patches: this makes no sense to
> me. For example, in this patch you reference new (and undocumented
> config options like CONFIG_E500_V1_V2) without ever using them.
>
> Please squash patches.
>
My objective was to have separate patch for every logical piece. That's
why I sent a series of patch.
I will request you to let them as series for better understanding of others.
May be in each patch before use of any #define (related to debugger), I
will write a comment.
Please suggest.
Regarding CONFIG_E500_V1_V2, Its description is also part of this patch
or is it not cleared ?
--Prabhakar
next prev parent reply other threads:[~2012-03-07 3:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-15 8:53 [U-Boot] [PATCH 1/4] doc: Add documentation for mpc85xx debugger support Prabhakar Kushwaha
2012-03-06 14:39 ` Wolfgang Denk
2012-03-07 3:32 ` Prabhakar Kushwaha [this message]
[not found] ` <071A08F2C6A57E4E94D980ECA553F874575244@039-SN1MPN1-005.039d.mgd.msft.net>
2012-03-07 6:24 ` Wolfgang Denk
2012-03-07 8:50 ` Prabhakar Kushwaha
2012-03-07 12:30 ` Wolfgang Denk
2012-03-13 7:14 ` Prabhakar Kushwaha
2012-03-14 9:35 ` Prabhakar Kushwaha
2012-03-14 19:30 ` Scott Wood
2012-03-15 3:51 ` Prabhakar Kushwaha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F56D6DF.3070701@freescale.com \
--to=prabhakar@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.