From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Reuben Dowle <Reuben.Dowle@navico.com>
Cc: "linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: [libsocketcan] Add can_get_link_stats() - v2
Date: Wed, 07 Mar 2012 10:44:53 +0100 [thread overview]
Message-ID: <4F572E15.2050304@pengutronix.de> (raw)
In-Reply-To: <6686CF564BC462488080D46D3C933CA4089AA6@EXCH02-AKLNZ.MARINE.NET.INT>
[-- Attachment #1: Type: text/plain, Size: 961 bytes --]
On 03/06/2012 08:04 PM, Reuben Dowle wrote:
> Add can_get_link_stats()
>
> This function gets link_stats64 information for the can interface.
> This structure can be for any interface (not just can), but it
> seems logical to keep functions for getting any statistics relevant
> to CAN in this library.
>
> Signed-off-by: Reuben Dowle <reuben.dowle@navico.com>
I was at iCC2012 CAN conference, now I've some more time to look at the
code. What about naming the function after the struct? Seems more
consistent to me.
> +int can_get_link_stats(const char *name, struct rtnl_link_stats64 *ls)
I mean "can_get_link_stats64" instead of "can_get_link_stats"?
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 262 bytes --]
next prev parent reply other threads:[~2012-03-07 9:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-06 19:04 [libsocketcan] Add can_get_link_stats() - v2 Reuben Dowle
2012-03-07 9:44 ` Marc Kleine-Budde [this message]
2012-03-07 23:45 ` Reuben Dowle
2012-03-08 8:49 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F572E15.2050304@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=Reuben.Dowle@navico.com \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.