From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] kvm: fill in padding to help valgrind Date: Wed, 07 Mar 2012 12:31:59 +0200 Message-ID: <4F57391F.1000101@redhat.com> References: <20120229155428.GA8413@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: unlisted-recipients:; Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org To: "Michael S. Tsirkin" Return-path: Received: from mx1.redhat.com ([209.132.183.28]:17065 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751536Ab2CGKcD (ORCPT ); Wed, 7 Mar 2012 05:32:03 -0500 In-Reply-To: <20120229155428.GA8413@redhat.com> Sender: kvm-owner@vger.kernel.org List-ID: On 02/29/2012 05:54 PM, Michael S. Tsirkin wrote: > valgrind warns about padding fields which are passed > to vcpu ioctls uninitialized. > This is not an error in practice because kvm ignored padding. > Since the ioctls in question are off data path and > the cost is zero anyway, initialize padding to 0 > to suppress these errors. > Applied to uq/master, thanks. -- error compiling committee.c: too many arguments to function From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49569) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5EAd-0001Pe-MO for qemu-devel@nongnu.org; Wed, 07 Mar 2012 05:32:36 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5EA7-00070R-G0 for qemu-devel@nongnu.org; Wed, 07 Mar 2012 05:32:35 -0500 Received: from mx1.redhat.com ([209.132.183.28]:5870) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5EA7-00070C-8g for qemu-devel@nongnu.org; Wed, 07 Mar 2012 05:32:03 -0500 Message-ID: <4F57391F.1000101@redhat.com> Date: Wed, 07 Mar 2012 12:31:59 +0200 From: Avi Kivity MIME-Version: 1.0 References: <20120229155428.GA8413@redhat.com> In-Reply-To: <20120229155428.GA8413@redhat.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] kvm: fill in padding to help valgrind List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: Marcelo Tosatti , qemu-devel@nongnu.org, kvm@vger.kernel.org On 02/29/2012 05:54 PM, Michael S. Tsirkin wrote: > valgrind warns about padding fields which are passed > to vcpu ioctls uninitialized. > This is not an error in practice because kvm ignored padding. > Since the ioctls in question are off data path and > the cost is zero anyway, initialize padding to 0 > to suppress these errors. > Applied to uq/master, thanks. -- error compiling committee.c: too many arguments to function