From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:47839 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107Ab2CGLkV (ORCPT ); Wed, 7 Mar 2012 06:40:21 -0500 Received: by bkcik5 with SMTP id ik5so5096651bkc.19 for ; Wed, 07 Mar 2012 03:40:20 -0800 (PST) Message-ID: <4F5748CC.9020601@ru.mvista.com> Date: Wed, 07 Mar 2012 15:38:52 +0400 From: Sergei Shtylyov MIME-Version: 1.0 To: Viresh Kumar CC: wim@iguana.be, linus.walleij@stericsson.com, srinidhi.kasagar@stericsson.com, spear-devel@list.st.com, viresh.linux@gmail.com, alan@lxorguk.ukuu.org.uk, linux-arm-kernel@lists.infradead.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 10/15] watchdog/mpcore_wdt: Add support for dev_pm_ops interface References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-watchdog-owner@vger.kernel.org List-Id: linux-watchdog@vger.kernel.org Hello. On 07-03-2012 14:27, Viresh Kumar wrote: > This patch adds dev_pm_ops support for standby/slepp/hibernate. > Signed-off-by: Viresh Kumar > --- > drivers/watchdog/mpcore_wdt.c | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > diff --git a/drivers/watchdog/mpcore_wdt.c b/drivers/watchdog/mpcore_wdt.c > index e02c02b..a099418 100644 > --- a/drivers/watchdog/mpcore_wdt.c > +++ b/drivers/watchdog/mpcore_wdt.c [...] > @@ -384,40 +385,39 @@ static int __devexit mpcore_wdt_remove(struct platform_device *pdev) [...] > /* work with hotplug and coldplug */ > MODULE_ALIAS("platform:mpcore_wdt"); > > static struct platform_driver mpcore_wdt_driver = { > .probe = mpcore_wdt_probe, > .remove = __devexit_p(mpcore_wdt_remove), > - .suspend = mpcore_wdt_suspend, > - .resume = mpcore_wdt_resume, > .shutdown = mpcore_wdt_shutdown, > .driver = { > .owner = THIS_MODULE, > .name = "mpcore_wdt", > + .pm = &mpcore_wdt_dev_pm_ops, Please align the right part of initializer like all above. WBR, Sergei From mboxrd@z Thu Jan 1 00:00:00 1970 From: sshtylyov@mvista.com (Sergei Shtylyov) Date: Wed, 07 Mar 2012 15:38:52 +0400 Subject: [PATCH 10/15] watchdog/mpcore_wdt: Add support for dev_pm_ops interface In-Reply-To: References: Message-ID: <4F5748CC.9020601@ru.mvista.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hello. On 07-03-2012 14:27, Viresh Kumar wrote: > This patch adds dev_pm_ops support for standby/slepp/hibernate. > Signed-off-by: Viresh Kumar > --- > drivers/watchdog/mpcore_wdt.c | 18 +++++++++--------- > 1 files changed, 9 insertions(+), 9 deletions(-) > diff --git a/drivers/watchdog/mpcore_wdt.c b/drivers/watchdog/mpcore_wdt.c > index e02c02b..a099418 100644 > --- a/drivers/watchdog/mpcore_wdt.c > +++ b/drivers/watchdog/mpcore_wdt.c [...] > @@ -384,40 +385,39 @@ static int __devexit mpcore_wdt_remove(struct platform_device *pdev) [...] > /* work with hotplug and coldplug */ > MODULE_ALIAS("platform:mpcore_wdt"); > > static struct platform_driver mpcore_wdt_driver = { > .probe = mpcore_wdt_probe, > .remove = __devexit_p(mpcore_wdt_remove), > - .suspend = mpcore_wdt_suspend, > - .resume = mpcore_wdt_resume, > .shutdown = mpcore_wdt_shutdown, > .driver = { > .owner = THIS_MODULE, > .name = "mpcore_wdt", > + .pm = &mpcore_wdt_dev_pm_ops, Please align the right part of initializer like all above. WBR, Sergei