From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH] stmmac: Allow stmmac to work with other PHY buses(v2). Date: Thu, 08 Mar 2012 10:16:04 +0100 Message-ID: <4F5878D4.1060603@openwrt.org> References: <1331012520-19574-1-git-send-email-peppe.cavallaro@st.com> <20120306.165703.277843706808689044.davem@davemloft.net> <4F57178C.7010407@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , peppe.cavallaro@st.com, netdev@vger.kernel.org To: srinivas.kandagatla@st.com Return-path: Received: from mail-bk0-f46.google.com ([209.85.214.46]:39387 "EHLO mail-bk0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755148Ab2CHJQ6 (ORCPT ); Thu, 8 Mar 2012 04:16:58 -0500 Received: by bkcik5 with SMTP id ik5so158770bkc.19 for ; Thu, 08 Mar 2012 01:16:56 -0800 (PST) In-Reply-To: <4F57178C.7010407@st.com> Sender: netdev-owner@vger.kernel.org List-ID: Hi, Le 03/07/12 09:08, Srinivas KANDAGATLA a =C3=A9crit : > David Miller wrote: >> From: Giuseppe CAVALLARO >> Date: Tue, 6 Mar 2012 06:42:00 +0100 >> >> >>> After commit "db8857b stmmac: use an unique MDIO bus name" and "90b= 9a54 >>> stmmac: fix phy naming inconsistency" stmmac cant work with other M= DIO >>> buses, because mdio_bus name is fixed in the dirver. >>> >> >> This sounds inaccurate, you're making it sound like these commits >> introduced this limitation, as far as I can tell they did not. >> >> > Thanks for your comments, > > Commit comment is true to some extent, before "db8857b stmmac: use an > unique MDIO bus name" and "a77e929 mdio-gpio: use an unique MDIO bus > name" we managed to get stmmac use mdio bus by specifying same id in > platform data of both the drivers. You could get it working with your platform supplied MDIO bus name more= =20 by accident than on purpose. > However after these commits this method was no more possible because > stmmac can connect to phys on stmmac-x mdio buses Only. > > I think, originally the problem was in stmmac to some extent which > became worse after adding prefix mdio bus. > Here is the new patch removing the misleading comments. Your new explanation makes much more sense to me now. Feel free to add = my: Acked-by: Florian Fainelli > > >> Before the MDIO bus name was just plain "%x" and the bus_id number >> was placed there. Then it became the same thing, except with some >> (potentially fixed) prefix. >> >> Nothing about that change makes any difference whatsoever about >> what you're modifications are trying to allow. >> >> BTW, also, commit "90b9a54" is ambiguous. >> >> > Actual commit was : 90b9a5454fd2e626aa1614fe9ece6b63a0dc37af > > Thanks, > srini >> [davem@bql net]$ git show 90b9a54 >> error: short SHA1 90b9a54 is ambiguous. >> error: short SHA1 90b9a54 is ambiguous. >> fatal: ambiguous argument '90b9a54': unknown revision or path not in= the working tree. >> >