From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wen Congyang Subject: Re: [PATCH 2/2 v3] deal with guest panicked event Date: Thu, 08 Mar 2012 18:11:46 +0800 Message-ID: <4F5885E2.8060701@cn.fujitsu.com> References: <4F58664D.1070800@cn.fujitsu.com> <4F5868C4.2090509@cn.fujitsu.com> <4F588504.5010205@siemens.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: kvm list , qemu-devel , "linux-kernel@vger.kernel.org" , Avi Kivity , "Daniel P. Berrange" , KAMEZAWA Hiroyuki , Gleb Natapov To: Jan Kiszka Return-path: In-Reply-To: <4F588504.5010205@siemens.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org At 03/08/2012 06:08 PM, Jan Kiszka Wrote: > On 2012-03-08 09:07, Wen Congyang wrote: >> When the host knows the guest is panicked, it will set >> exit_reason to KVM_EXIT_GUEST_PANICKED. So if qemu receive >> this exit_reason, we can send a event to tell management >> application that the guest is panicked and set the guest >> status to RUN_STATE_PANICKED. >> >> Signed-off-by: Wen Congyang >> --- >> kvm-all.c | 4 ++++ >> monitor.c | 3 +++ >> monitor.h | 1 + >> qapi-schema.json | 2 +- >> qmp.c | 3 ++- >> vl.c | 1 + >> 6 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index 77eadf6..01062af 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -1290,6 +1290,10 @@ int kvm_cpu_exec(CPUState *env) >> (uint64_t)run->hw.hardware_exit_reason); >> ret = -1; >> break; >> + case KVM_EXIT_GUEST_PANICKED: >> + monitor_protocol_event(QEVENT_GUEST_PANICKED, NULL); >> + vm_stop(RUN_STATE_PANICKED); >> + break; > > You're still lacking "ret = -1;". Sorry, I forgot it... Thanks Wen Congyang > > Jan > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49941) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5aIp-0002Kn-DS for qemu-devel@nongnu.org; Thu, 08 Mar 2012 05:10:37 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5aIV-0006Mz-Au for qemu-devel@nongnu.org; Thu, 08 Mar 2012 05:10:30 -0500 Received: from [222.73.24.84] (port=14425 helo=song.cn.fujitsu.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5aIU-0006LP-W7 for qemu-devel@nongnu.org; Thu, 08 Mar 2012 05:10:11 -0500 Message-ID: <4F5885E2.8060701@cn.fujitsu.com> Date: Thu, 08 Mar 2012 18:11:46 +0800 From: Wen Congyang MIME-Version: 1.0 References: <4F58664D.1070800@cn.fujitsu.com> <4F5868C4.2090509@cn.fujitsu.com> <4F588504.5010205@siemens.com> In-Reply-To: <4F588504.5010205@siemens.com> Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=ISO-8859-1 Subject: Re: [Qemu-devel] [PATCH 2/2 v3] deal with guest panicked event List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Jan Kiszka Cc: Gleb Natapov , kvm list , qemu-devel , "linux-kernel@vger.kernel.org" , Avi Kivity , KAMEZAWA Hiroyuki At 03/08/2012 06:08 PM, Jan Kiszka Wrote: > On 2012-03-08 09:07, Wen Congyang wrote: >> When the host knows the guest is panicked, it will set >> exit_reason to KVM_EXIT_GUEST_PANICKED. So if qemu receive >> this exit_reason, we can send a event to tell management >> application that the guest is panicked and set the guest >> status to RUN_STATE_PANICKED. >> >> Signed-off-by: Wen Congyang >> --- >> kvm-all.c | 4 ++++ >> monitor.c | 3 +++ >> monitor.h | 1 + >> qapi-schema.json | 2 +- >> qmp.c | 3 ++- >> vl.c | 1 + >> 6 files changed, 12 insertions(+), 2 deletions(-) >> >> diff --git a/kvm-all.c b/kvm-all.c >> index 77eadf6..01062af 100644 >> --- a/kvm-all.c >> +++ b/kvm-all.c >> @@ -1290,6 +1290,10 @@ int kvm_cpu_exec(CPUState *env) >> (uint64_t)run->hw.hardware_exit_reason); >> ret = -1; >> break; >> + case KVM_EXIT_GUEST_PANICKED: >> + monitor_protocol_event(QEVENT_GUEST_PANICKED, NULL); >> + vm_stop(RUN_STATE_PANICKED); >> + break; > > You're still lacking "ret = -1;". Sorry, I forgot it... Thanks Wen Congyang > > Jan >