On 03/08/2012 06:52 PM, Kukjin Kim wrote: > On 03/07/12 04:28, Kukjin Kim wrote: >> On 02/10/12 10:26, Mark Brown wrote: >>> On Fri, Feb 10, 2012 at 11:35:41AM +0100, Lukasz Majewski wrote: >>>> From: Joonyoung Shim >>>> >>>> This patch supports to control usb otg phy of S3C64XX. Currently, the >>>> driver for usb otg controls usb otg phy but it can be removed by this >>>> patch. >>> >>> Acked-by: Mark Brown >> >> Applied, thanks. >> > > Oops, following error happened with s5pv210_defconfig after applying > this. > > arch/arm/plat-samsung/built-in.o: In function `s3c_hsotg_set_platdata': > arch/arm/plat-samsung/devs.c:1449: undefined reference to > `s5p_usb_phy_init' > arch/arm/plat-samsung/devs.c:1449: undefined reference to > `s5p_usb_phy_init' > arch/arm/plat-samsung/devs.c:1451: undefined reference to > `s5p_usb_phy_exit' > arch/arm/plat-samsung/devs.c:1451: undefined reference to > `s5p_usb_phy_exit' > make: *** [.tmp_vmlinux1] Error 1 > Also the s5pv210 needs setup-usb-phy.c file. I think the attached patch will solve this errors. This patch was tested only compile. Thanks.