From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Jeff King <peff@peff.net>
Cc: "Junio C Hamano" <gitster@pobox.com>, "Brodie Rao" <brodie@sf.io>,
"Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org
Subject: Re: [PATCH] archive: fix archive generation for empty trees
Date: Thu, 08 Mar 2012 18:46:02 +0100 [thread overview]
Message-ID: <4F58F05A.1010606@lsrfire.ath.cx> (raw)
In-Reply-To: <20120308071559.GF7643@sigill.intra.peff.net>
Am 08.03.2012 08:15, schrieb Jeff King:
> On Wed, Mar 07, 2012 at 10:38:07PM -0800, Junio C Hamano wrote:
>
>>> ... However, prefix_pathspec does a lot of magic parsing;
>>> it's unclear to me whether this is all in support of properly
>>> adding the prefix, or if its side effects are important.
>>
>> These "magic" are for things like :(root)/path that will explicitly
>> refuse the prefix when run from a subdirectory.
>
> Yeah, that was my impression. In that case, I would think we could get
> rid of the get_pathspec call entirely, as it is purely about fixing-up
> prefixes, and we know that we have none.
Yes, I think you're right. Not sure why I didn't do that in ebfbdb34,
when that empty prefix was introduced instead.
René
next prev parent reply other threads:[~2012-03-08 17:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 0:09 [PATCH] archive: fix archive generation for empty trees Brodie Rao
2012-03-08 5:55 ` Jeff King
2012-03-08 6:38 ` Junio C Hamano
2012-03-08 7:15 ` Jeff King
2012-03-08 17:46 ` René Scharfe [this message]
2012-03-09 0:06 ` Brodie Rao
2012-03-09 7:30 ` René Scharfe
2012-03-08 17:46 ` René Scharfe
2012-03-09 0:08 ` Brodie Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F58F05A.1010606@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=brodie@sf.io \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.