From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:49833) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5kuA-0007zx-2T for qemu-devel@nongnu.org; Thu, 08 Mar 2012 16:29:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5ku7-000497-78 for qemu-devel@nongnu.org; Thu, 08 Mar 2012 16:29:45 -0500 Received: from cantor2.suse.de ([195.135.220.15]:53222 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5ku7-00048s-0P for qemu-devel@nongnu.org; Thu, 08 Mar 2012 16:29:43 -0500 Message-ID: <4F5924C4.3020303@suse.de> Date: Thu, 08 Mar 2012 22:29:40 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <1331198182-11516-1-git-send-email-kraxel@redhat.com> In-Reply-To: <1331198182-11516-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RfC PATCH 0/2] usb: reorganize source files. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Gerd Hoffmann , Anthony Liguori Cc: qemu-devel@nongnu.org Am 08.03.2012 10:16, schrieb Gerd Hoffmann: > Plan is basically to move all usb stuff to hw/usb/ >=20 > Comments? hw/usb/ is fine with me (hw/ide/ is precedence), but I strongly dislike the dev-*.c convention you've used: For one thing, we'd have to rename 90+% of hw/ to be consistent. For another, dev-foo.c is not natural English for a certain type of device - foo-dev.c would be better but I'd prefer without "dev", i.e., hw/usb/{audio,ccid,...}.c. And then of course only devices should go into hw/. Also, Anthony was recently talking about building up a new Linux-like directory structure inside qom/ but I don't see that working yet and renames are cheap in git anyway, so I guess that's no reason against hw/usb/ as an interim improvement. Anthony further said he had a patch to avoid having to create subdirectories in configure for the out-of-tree builds. That would simplify both this and my *-user QOM series. Any update on that? Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg