From: Eric Sandeen <sandeen@redhat.com>
To: Mark Tinguely <tinguely@sgi.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs-oss <xfs@oss.sgi.com>
Subject: [PATCH] xfs_io: allow -F in open args
Date: Thu, 08 Mar 2012 16:20:44 -0600 [thread overview]
Message-ID: <4F5930BC.7040106@redhat.com> (raw)
In-Reply-To: <4F592728.9060706@sgi.com>
Now that -F ("foreign") is automagic, we should no longer list
it in the help output for open, but we should still accept
it for compatibility; esp. as it is still in the case statement.
Oops.
Reported-by: Mark Tinguely <tinguely@sgi.com>
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/io/open.c b/io/open.c
index ac39ccc..46538ba 100644
--- a/io/open.c
+++ b/io/open.c
@@ -240,7 +240,6 @@ open_help(void)
"\n"
" Opens a file for subsequent use by all of the other xfs_io commands.\n"
" With no arguments, open uses the stat command to show the current file.\n"
-" -F -- foreign filesystem file, disallow XFS-specific commands\n"
" -a -- open with the O_APPEND flag (append-only mode)\n"
" -d -- open with O_DIRECT (non-buffered IO, note alignment constraints)\n"
" -f -- open with O_CREAT (create the file if it doesn't exist)\n"
@@ -274,7 +273,7 @@ open_f(
return 0;
}
- while ((c = getopt(argc, argv, "Racdfm:nrstx")) != EOF) {
+ while ((c = getopt(argc, argv, "FRacdfm:nrstx")) != EOF) {
switch (c) {
case 'F':
/* Ignored / deprecated now, handled automatically */
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-03-08 22:20 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-02 17:35 [PATCH] xfs_io: deprecate the "-F" foreign flag Eric Sandeen
2012-02-03 15:04 ` Christoph Hellwig
2012-02-03 16:10 ` Eric Sandeen
2012-02-13 19:00 ` Christoph Hellwig
2012-02-14 17:18 ` Eric Sandeen
2012-03-08 21:39 ` Mark Tinguely
2012-03-08 22:16 ` Eric Sandeen
2012-03-08 22:20 ` Eric Sandeen [this message]
2012-03-08 22:37 ` [PATCH] xfs_io: allow -F in open args Mark Tinguely
2012-03-08 22:37 ` Eric Sandeen
2012-03-08 22:39 ` Mark Tinguely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5930BC.7040106@redhat.com \
--to=sandeen@redhat.com \
--cc=hch@infradead.org \
--cc=tinguely@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.