All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Sandeen <sandeen@sandeen.net>
To: Ben Myers <bpm@sgi.com>
Cc: xfs@oss.sgi.com, Mitsuo Hayasaka <mitsuo.hayasaka.hu@hitachi.com>,
	Christoph Hellwig <hch@lst.de>, Mark Tinguely <tinguely@sgi.com>
Subject: Re: [patch 1/1] xfstests: update inode softlimit output in 050
Date: Thu, 08 Mar 2012 16:42:04 -0600	[thread overview]
Message-ID: <4F5935BC.4050104@sandeen.net> (raw)
In-Reply-To: <20120222182832.076759206@sgi.com>

On 2/22/12 12:27 PM, Ben Myers wrote:

> With Mitsuo Hayasaka's kernel patch "xfs: change available ranges of softlimit
> and hardlimit in quota check", xfs quota behavior is slightly different.
> 
> This needs to be reflected in test 050.  The new behavior is that we only start
> the timer when we're above soft inode quota, and we don't start the timer when
> we're at or below.
> 
> Signed-off-by: Ben Myers <bpm@sgi.com>
> Index: xfstests/050.out
> ===================================================================
> --- xfstests.orig/050.out
> +++ xfstests/050.out
> @@ -20,7 +20,7 @@ realtime =RDEV extsz=XXX blocks=XXX, rte
>  
>  *** push past the soft block limit
>  [ROOT] 0 0 0 00 [--------] 3 0 0 00 [--------] 0 0 0 00 [--------]
> -[NAME] 140 100 500 00 [7 days] 4 4 10 00 [7 days] 0 0 0 00 [--------]
> +[NAME] 140 100 500 00 [7 days] 4 4 10 00 [--------] 0 0 0 00 [--------]

...


Hm, but now old kernels would fail.

Maybe it's better to go 1 past the limit in the test, rather than meet it, and then it'd fail on both old & new kernels?

-Eric

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2012-03-08 22:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-22 18:27 [patch 0/1] xfstests: fix test 050 Ben Myers
2012-02-22 18:27 ` [patch 1/1] xfstests: update inode softlimit output in 050 Ben Myers
2012-03-08 22:42   ` Eric Sandeen [this message]
2012-03-09  2:17     ` Ben Myers
2012-03-31 20:12   ` [patch 1/1] 050: update inode softlimit output Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F5935BC.4050104@sandeen.net \
    --to=sandeen@sandeen.net \
    --cc=bpm@sgi.com \
    --cc=hch@lst.de \
    --cc=mitsuo.hayasaka.hu@hitachi.com \
    --cc=tinguely@sgi.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.