diff for duplicates of <4F598204.9030504@gmail.com> diff --git a/a/1.txt b/N1/1.txt index a74a711..5cbf8f7 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,13 +1,13 @@ On 03/09/2012 11:40 AM, KAMEZAWA Hiroyuki wrote: > On Tue, 6 Mar 2012 20:13:24 +0800 -> Sha Zhengju<handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote: +> Sha Zhengju<handai.szj@gmail.com> wrote: > ->> From: Sha Zhengju<handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org> +>> From: Sha Zhengju<handai.szj@taobao.com> >> >> When the last event is unregistered, there is no need to keep the spare >> array anymore. So free it to avoid memory leak. >> ->> Signed-off-by: Sha Zhengju<handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org> +>> Signed-off-by: Sha Zhengju<handai.szj@taobao.com> >> >> --- >> mm/memcontrol.c | 6 ++++++ @@ -28,7 +28,7 @@ On 03/09/2012 11:40 AM, KAMEZAWA Hiroyuki wrote: >> + } >> + > Could you clear thresholds->primary ? I don't like a pointer points to freed memory. -Do you meaning I should set ‘thresholds->primary = NULL‘ ？ +Do you meaning I should set a??thresholds->primary = NULLa?? i 1/4 ? But the following rcu_assign_pointer will do this : + /* If all events are unregistered, free the spare array */ @@ -40,3 +40,10 @@ But the following rcu_assign_pointer will do this : rcu_assign_pointer(thresholds->primary, new);<---------*HERE* /* To be sure that nobody uses thresholds */ + +-- +To unsubscribe, send a message with 'unsubscribe linux-mm' in +the body to majordomo@kvack.org. For more info on Linux MM, +see: http://www.linux-mm.org/ . +Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ +Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a> diff --git a/a/content_digest b/N1/content_digest index d909506..f6a72a9 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,26 +1,25 @@ "ref\01331036004-7550-1-git-send-email-handai.szj@taobao.com\0" "ref\020120309124021.810f5267.kamezawa.hiroyu@jp.fujitsu.com\0" - "ref\020120309124021.810f5267.kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org\0" - "From\0Sha Zhengju <handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>\0" + "From\0Sha Zhengju <handai.szj@gmail.com>\0" "Subject\0Re: [PATCH] memcg: Free spare array to avoid memory leak\0" "Date\0Fri, 09 Mar 2012 12:07:32 +0800\0" - "To\0KAMEZAWA Hiroyuki <kamezawa.hiroyu-+CUm20s59erQFUHtdCDX3A@public.gmane.org>\0" - "Cc\0linux-mm-Bw31MaZKKs3YtjvyW6yDsg@public.gmane.org" - cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org - kirill-oKw7cIdHH8eLwutG50LtGA@public.gmane.org - " Sha Zhengju <handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>\0" + "To\0KAMEZAWA Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>\0" + "Cc\0linux-mm@kvack.org" + cgroups@vger.kernel.org + kirill@shutemov.name + " Sha Zhengju <handai.szj@taobao.com>\0" "\00:1\0" "b\0" "On 03/09/2012 11:40 AM, KAMEZAWA Hiroyuki wrote:\n" "> On Tue, 6 Mar 2012 20:13:24 +0800\n" - "> Sha Zhengju<handai.szj-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:\n" + "> Sha Zhengju<handai.szj@gmail.com> wrote:\n" ">\n" - ">> From: Sha Zhengju<handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>\n" + ">> From: Sha Zhengju<handai.szj@taobao.com>\n" ">>\n" ">> When the last event is unregistered, there is no need to keep the spare\n" ">> array anymore. So free it to avoid memory leak.\n" ">>\n" - ">> Signed-off-by: Sha Zhengju<handai.szj-3b8fjiQLQpfQT0dZR+AlfA@public.gmane.org>\n" + ">> Signed-off-by: Sha Zhengju<handai.szj@taobao.com>\n" ">>\n" ">> ---\n" ">> mm/memcontrol.c | 6 ++++++\n" @@ -41,7 +40,7 @@ ">> +\t}\n" ">> +\n" "> Could you clear thresholds->primary ? I don't like a pointer points to freed memory.\n" - "Do you meaning I should set \342\200\230thresholds->primary = NULL\342\200\230 \357\274\237\n" + "Do you meaning I should set a??thresholds->primary = NULLa?? i 1/4 ?\n" "But the following rcu_assign_pointer will do this :\n" "\n" "+\t/* If all events are unregistered, free the spare array */\n" @@ -52,6 +51,13 @@ "+\n" " \trcu_assign_pointer(thresholds->primary, new);<---------*HERE*\n" "\n" - " \t/* To be sure that nobody uses thresholds */" + " \t/* To be sure that nobody uses thresholds */\n" + "\n" + "--\n" + "To unsubscribe, send a message with 'unsubscribe linux-mm' in\n" + "the body to majordomo@kvack.org. For more info on Linux MM,\n" + "see: http://www.linux-mm.org/ .\n" + "Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/\n" + "Don't email: <a href=mailto:\"dont@kvack.org\"> email@kvack.org </a>" -36ce1a0796a41f9fec2d3f9fae89a741109c1b67269585368311b8dafc18cc8d +2320c620d9db4210414b3dfd9d78472337710d50fdb2fb6b16f1be484c176e37
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.