From: Paolo Bonzini <pbonzini@redhat.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Kevin Wolf <kwolf@redhat.com>,
mst@redhat.com, agraf@suse.de, qemu-devel@nongnu.org,
eduard.munteanu@linux360.ro, rth@twiddle.net
Subject: Re: [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io
Date: Fri, 09 Mar 2012 11:01:16 +0100 [thread overview]
Message-ID: <4F59D4EC.7060506@redhat.com> (raw)
In-Reply-To: <1331269308-22372-2-git-send-email-david@gibson.dropbear.id.au>
Il 09/03/2012 06:01, David Gibson ha scritto:
> Currently dma_bdrv_io() takes a 'to_dev' boolean parameter to
> determine the direction of DMA it is emulating. We already have a
> DMADirection enum designed specifically to encode DMA directions.
> This patch uses it for dma_bdrv_io() as well. This involves removing
> the DMADirection definition from the #ifdef it was inside, but since that
> only existed to protect the definition of dma_addr_t from places where
> config.h is not included, there wasn't any reason for it to be there in
> the first place.
Looks good, but please use this for dma_buf_* too.
Paolo
next prev parent reply other threads:[~2012-03-09 10:02 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 5:01 [Qemu-devel] [0/13] Implement support for guest visible IOMMUs David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io David Gibson
2012-03-09 9:34 ` Kevin Wolf
2012-03-09 10:01 ` Paolo Bonzini [this message]
2012-03-13 5:53 ` David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 02/13] Better support for dma_addr_t variables David Gibson
2012-03-09 10:00 ` Paolo Bonzini
2012-03-09 5:01 ` [Qemu-devel] [PATCH 03/13] usb-xhci: Use PCI DMA helper functions David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 04/13] Implement cpu_physical_memory_zero() David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 05/13] iommu: Add universal DMA helper functions David Gibson
2012-03-09 10:06 ` Paolo Bonzini
2012-03-09 11:19 ` David Gibson
2012-03-09 11:55 ` Paolo Bonzini
2012-03-09 5:01 ` [Qemu-devel] [PATCH 06/13] usb-ohci: Use " David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 07/13] iommu: Make sglists and dma_bdrv helpers use new universal DMA helpers David Gibson
2012-03-09 9:43 ` Kevin Wolf
2012-03-13 10:42 ` David Gibson
2012-03-13 11:55 ` Kevin Wolf
2012-03-09 10:11 ` Paolo Bonzini
2012-03-13 6:37 ` David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 08/13] ide/ahci: Use universal DMA helper functions David Gibson
2012-03-09 9:48 ` Kevin Wolf
2012-03-10 5:30 ` David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 09/13] usb: Convert usb_packet_{map, unmap} to universal DMA helpers David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 10/13] iommu: Introduce IOMMU emulation infrastructure David Gibson
2012-03-09 10:23 ` Paolo Bonzini
2012-03-13 5:07 ` David Gibson
2012-03-13 13:56 ` Alexander Graf
2012-03-13 14:04 ` David Gibson
2012-03-13 14:37 ` Alexander Graf
2012-03-14 9:05 ` David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 11/13] pseries: Convert sPAPR TCEs to use generic IOMMU infrastructure David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 12/13] iommu: Allow PCI to use " David Gibson
2012-03-09 5:01 ` [Qemu-devel] [PATCH 13/13] pseries: Implement IOMMU and DMA for PAPR PCI devices David Gibson
2012-03-09 10:23 ` Paolo Bonzini
2012-03-09 10:58 ` David Gibson
2012-03-11 2:02 ` Benjamin Herrenschmidt
-- strict thread matches above, loose matches on Subject: below --
2012-03-22 2:14 [Qemu-devel] [0/13] RFC: Guest visible IOMMU David Gibson
2012-03-22 2:14 ` [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io David Gibson
2012-03-01 5:35 [Qemu-devel] [0/13] RFC: Support for guest-visible IOMMUs David Gibson
2012-03-01 5:35 ` [Qemu-devel] [PATCH 01/13] Use DMADirection type for dma_bdrv_io David Gibson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F59D4EC.7060506@redhat.com \
--to=pbonzini@redhat.com \
--cc=agraf@suse.de \
--cc=david@gibson.dropbear.id.au \
--cc=eduard.munteanu@linux360.ro \
--cc=kwolf@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.