From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:47531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5yPr-0004Oz-MM for qemu-devel@nongnu.org; Fri, 09 Mar 2012 06:55:29 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S5yPl-0008K6-GT for qemu-devel@nongnu.org; Fri, 09 Mar 2012 06:55:23 -0500 Received: from mx1.redhat.com ([209.132.183.28]:59605) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S5yPl-0008Jy-8n for qemu-devel@nongnu.org; Fri, 09 Mar 2012 06:55:17 -0500 Message-ID: <4F59EF9B.3050900@redhat.com> Date: Fri, 09 Mar 2012 12:55:07 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1331269308-22372-1-git-send-email-david@gibson.dropbear.id.au> <1331269308-22372-6-git-send-email-david@gibson.dropbear.id.au> <4F59D631.3050702@redhat.com> <20120309111914.GB24916@truffala.fritz.box> In-Reply-To: <20120309111914.GB24916@truffala.fritz.box> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 05/13] iommu: Add universal DMA helper functions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, mst@redhat.com, Joerg Rodel , agraf@suse.de, eduard.munteanu@linux360.ro, rth@twiddle.net Il 09/03/2012 12:19, David Gibson ha scritto: >> > >> > This is opposite to the convention of dma_buf_read/dma_buf_write, which >> > is from the point of view of the device. > Uh, these are from the point of view of the device - the device writes > to memory == transfer from device. Right, dma_buf_read = "read from device". The idea with dma_buf_read was to make it the same as dma_bdrv_read(). > More importantly, this is the same > convention as cpu_physical_memory_{read,write}() which is what these > generally replace. Understood. My point was not really to bikeshed, just to note that probably dma_buf_read/dma_buf_write become very confusing now. So it is best to remove them and just replace it with dma_buf_rw and a DMADirection argument). Can you do that? Thanks, Paolo