From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:39201)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S5zql-0005C8-Ru
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 08:27:20 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S5zqN-0003Hl-PZ
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 08:27:15 -0500
Received: from cantor2.suse.de ([195.135.220.15]:34469 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S5zqN-0003HN-Iu
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 08:26:51 -0500
Message-ID: <4F5A0519.8020307@suse.de>
Date: Fri, 09 Mar 2012 14:26:49 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1331297197-4289-1-git-send-email-kwolf@redhat.com>
	<1331297197-4289-4-git-send-email-kwolf@redhat.com>
In-Reply-To: <1331297197-4289-4-git-send-email-kwolf@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org

Am 09.03.2012 13:46, schrieb Kevin Wolf:
> Runs the full qemu-iotests suite for various image formats.
>=20
> Signed-off-by: Kevin Wolf <kwolf@redhat.com>
> ---
>  tests/Makefile       |    6 +++++-
>  tests/check-block.sh |   21 +++++++++++++++++++++
>  2 files changed, 26 insertions(+), 1 deletions(-)
>  create mode 100755 tests/check-block.sh
>=20
> diff --git a/tests/Makefile b/tests/Makefile
> index 571ad42..6b4f4aa 100644
> --- a/tests/Makefile
> +++ b/tests/Makefile
> @@ -47,6 +47,10 @@ test-qmp-commands: test-qmp-commands.o $(qobject-obj=
-y) $(qapi-obj-y) $(tools-ob
> =20
>  $(SRC_PATH)/tests/qemu-iotests-quick.sh: qemu-img qemu-io
> =20
> -.PHONY: check
> +
> +.PHONY: check check-block

Minor nit: Since you already add a second empty line before .PHONY, care
to also add one before check: analog to check-block:?

>  check: $(CHECKS)
>  	$(call quiet-command, gtester $(CHECKS), "  CHECK")
> +
> +check-block:
> +	$(call quiet-command, $(SRC_PATH)/tests/check-block.sh , "  CHECK")

Please use $(SHELL) here.

Andreas

> diff --git a/tests/check-block.sh b/tests/check-block.sh
> new file mode 100755
> index 0000000..b9d9c6a
> --- /dev/null
> +++ b/tests/check-block.sh
> @@ -0,0 +1,21 @@
> +#!/bin/sh
[...]

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg