From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:58193)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S60Yz-0002YM-GS
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:13:03 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S60Yq-00074e-VO
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:12:57 -0500
Received: from cantor2.suse.de ([195.135.220.15]:37690 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1S60Yq-00074N-Ok
	for qemu-devel@nongnu.org; Fri, 09 Mar 2012 09:12:48 -0500
Message-ID: <4F5A0FDE.9030503@suse.de>
Date: Fri, 09 Mar 2012 15:12:46 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1331297197-4289-1-git-send-email-kwolf@redhat.com>
	<1331297197-4289-4-git-send-email-kwolf@redhat.com>
	<4F5A0519.8020307@suse.de> <4F5A0E3B.1080200@redhat.com>
In-Reply-To: <4F5A0E3B.1080200@redhat.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH v2 3/3] Add 'make check-block'
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: stefanha@gmail.com, qemu-devel@nongnu.org

Am 09.03.2012 15:05, schrieb Kevin Wolf:
> Am 09.03.2012 14:26, schrieb Andreas F=E4rber:
>> Am 09.03.2012 13:46, schrieb Kevin Wolf:
>>>  check: $(CHECKS)
>>>  	$(call quiet-command, gtester $(CHECKS), "  CHECK")
>>> +
>>> +check-block:
>>> +	$(call quiet-command, $(SRC_PATH)/tests/check-block.sh , "  CHECK")
>>
>> Please use $(SHELL) here.
>=20
> Ok, I can do that. But what's the difference?

The difference is that /bin/sh can be dash or some non-POSIX-compliant
shell. There's an open bug about Solaris 10 needing some oddly named
shell instead of /bin/sh, for instance. By executing ./check-block.sh
via shebang, a shell different from the one the user has explicitly used
for configure gets used. There's an example of $(SHELL) use in ../Makefil=
e.

An alternative would be inlining your script into the Makefile.

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg