From: Stephen Warren <swarren@wwwdotorg.org>
To: Thierry Reding <thierry.reding@avionic-design.de>
Cc: linux-tegra@vger.kernel.org, Liam Girdwood <lrg@ti.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
linux-pci@vger.kernel.org,
Grant Likely <grant.likely@secretlab.ca>,
Rob Herring <rob.herring@calxeda.com>,
devicetree-discuss@lists.ozlabs.org,
Russell King <linux@arm.linux.org.uk>,
linux-arm-kernel@lists.infradead.org,
Colin Cross <ccross@android.com>, Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver
Date: Fri, 09 Mar 2012 09:42:32 -0700 [thread overview]
Message-ID: <4F5A32F8.80001@wwwdotorg.org> (raw)
In-Reply-To: <20120309063739.GC25208@avionic-0098.mockup.avionic-design.de>
On 03/08/2012 11:37 PM, Thierry Reding wrote:
> * Stephen Warren wrote:
>> On 03/08/2012 07:51 AM, Thierry Reding wrote:
>>> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
...
>>> diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.h
>>
>>> +#define TEGRA_PCIE_MAX_PORTS 2
>>> +
>>> +struct tegra_pcie_pdata {
>>> + int (*init)(struct platform_device *pdev);
>>> + int (*exit)(struct platform_device *pdev);
>>> + bool enable_ports[TEGRA_PCIE_MAX_PORTS];
>>> +};
>>
>> That's a somewhat odd place to put the header; a dedicated
>> mach-tegra/include/mach/tegra_pcie_pdata.h or
>> include/linux/platform_data/tegra_pcie.h might make more sense.
>
> mach-tegra/include/mach/pcie.h perhaps? That would be less redundant.
New files in that directory should have tegra in the name somewhere, so
that when multi-SoC kernels are built, and multiple mach-*/include/mach
directories are in the include path (or files get moved from those paths
into a single common place), you know which include file you're getting.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Warren <swarren-3lzwWm7+Weoh9ZMKESR00Q@public.gmane.org>
To: Thierry Reding
<thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Liam Girdwood <lrg-l0cyMroinI0@public.gmane.org>,
Mark Brown
<broonie-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org>,
Jesse Barnes <jbarnes-Y1mF5jBUw70BENJcbMCuUQ@public.gmane.org>,
linux-pci-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Grant Likely
<grant.likely-s3s/WqlpOiPyB63q8FvJNQ@public.gmane.org>,
Rob Herring <rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org>,
devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org,
Russell King <linux-lFZ/pmaqli7XmaaqVzeoHQ@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Colin Cross <ccross-z5hGa2qSFaRBDgjK7y7TUQ@public.gmane.org>,
Olof Johansson <olof-nZhT3qVonbNeoWH0uzbU5w@public.gmane.org>
Subject: Re: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver
Date: Fri, 09 Mar 2012 09:42:32 -0700 [thread overview]
Message-ID: <4F5A32F8.80001@wwwdotorg.org> (raw)
In-Reply-To: <20120309063739.GC25208-RM9K5IK7kjIQXX3q8xo1gnVAuStQJXxyR5q1nwbD4aMs9pC9oP6+/A@public.gmane.org>
On 03/08/2012 11:37 PM, Thierry Reding wrote:
> * Stephen Warren wrote:
>> On 03/08/2012 07:51 AM, Thierry Reding wrote:
>>> Signed-off-by: Thierry Reding <thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org>
...
>>> diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.h
>>
>>> +#define TEGRA_PCIE_MAX_PORTS 2
>>> +
>>> +struct tegra_pcie_pdata {
>>> + int (*init)(struct platform_device *pdev);
>>> + int (*exit)(struct platform_device *pdev);
>>> + bool enable_ports[TEGRA_PCIE_MAX_PORTS];
>>> +};
>>
>> That's a somewhat odd place to put the header; a dedicated
>> mach-tegra/include/mach/tegra_pcie_pdata.h or
>> include/linux/platform_data/tegra_pcie.h might make more sense.
>
> mach-tegra/include/mach/pcie.h perhaps? That would be less redundant.
New files in that directory should have tegra in the name somewhere, so
that when multi-SoC kernels are built, and multiple mach-*/include/mach
directories are in the include path (or files get moved from those paths
into a single common place), you know which include file you're getting.
WARNING: multiple messages have this Message-ID (diff)
From: swarren@wwwdotorg.org (Stephen Warren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver
Date: Fri, 09 Mar 2012 09:42:32 -0700 [thread overview]
Message-ID: <4F5A32F8.80001@wwwdotorg.org> (raw)
In-Reply-To: <20120309063739.GC25208@avionic-0098.mockup.avionic-design.de>
On 03/08/2012 11:37 PM, Thierry Reding wrote:
> * Stephen Warren wrote:
>> On 03/08/2012 07:51 AM, Thierry Reding wrote:
>>> Signed-off-by: Thierry Reding <thierry.reding@avionic-design.de>
...
>>> diff --git a/arch/arm/mach-tegra/board.h b/arch/arm/mach-tegra/board.h
>>
>>> +#define TEGRA_PCIE_MAX_PORTS 2
>>> +
>>> +struct tegra_pcie_pdata {
>>> + int (*init)(struct platform_device *pdev);
>>> + int (*exit)(struct platform_device *pdev);
>>> + bool enable_ports[TEGRA_PCIE_MAX_PORTS];
>>> +};
>>
>> That's a somewhat odd place to put the header; a dedicated
>> mach-tegra/include/mach/tegra_pcie_pdata.h or
>> include/linux/platform_data/tegra_pcie.h might make more sense.
>
> mach-tegra/include/mach/pcie.h perhaps? That would be less redundant.
New files in that directory should have tegra in the name somewhere, so
that when multi-SoC kernels are built, and multiple mach-*/include/mach
directories are in the include path (or files get moved from those paths
into a single common place), you know which include file you're getting.
next prev parent reply other threads:[~2012-03-09 16:42 UTC|newest]
Thread overview: 124+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-08 14:51 [PATCH 00/11] ARM: tegra: Add PCIe device tree support Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` [PATCH 01/11] drivercore: Add driver probe deferral mechanism Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-19 23:12 ` Sylwester Nawrocki
2012-03-19 23:12 ` Sylwester Nawrocki
2012-03-19 23:12 ` Sylwester Nawrocki
2012-03-20 14:21 ` Grant Likely
2012-03-20 14:21 ` Grant Likely
2012-03-20 14:21 ` Grant Likely
2012-03-08 14:51 ` [PATCH 02/11] regulator: Support driver probe deferral Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` [PATCH 03/11] regulator: fixed: " Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-11 12:58 ` Mark Brown
2012-03-11 12:58 ` Mark Brown
2012-03-08 14:51 ` [PATCH 04/11] regulator: tps6586x: fix typo in debug message Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 19:08 ` Mark Brown
2012-03-08 19:08 ` Mark Brown
2012-03-08 19:08 ` Mark Brown
2012-03-08 14:51 ` [PATCH 05/11] tps6586x: Add device-tree support Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 15:06 ` Mark Brown
2012-03-08 15:06 ` Mark Brown
2012-03-08 15:15 ` Thierry Reding
2012-03-08 15:15 ` Thierry Reding
2012-03-08 15:15 ` Thierry Reding
2012-03-08 15:17 ` Mark Brown
2012-03-08 15:17 ` Mark Brown
2012-03-08 15:45 ` Thierry Reding
2012-03-08 15:45 ` Thierry Reding
2012-03-09 5:15 ` Grant Likely
2012-03-09 5:15 ` Grant Likely
2012-03-09 5:15 ` Grant Likely
2012-03-09 7:53 ` Thierry Reding
2012-03-09 7:53 ` Thierry Reding
2012-03-09 7:53 ` Thierry Reding
2012-03-08 14:51 ` [PATCH 06/11] PCI: Keep pci_fixup_irqs() around after init Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 17:27 ` Bjorn Helgaas
2012-03-08 17:27 ` Bjorn Helgaas
2012-03-08 17:27 ` Bjorn Helgaas
2012-03-08 18:37 ` Thierry Reding
2012-03-08 18:37 ` Thierry Reding
2012-03-08 18:41 ` Bjorn Helgaas
2012-03-08 18:41 ` Bjorn Helgaas
2012-03-08 14:51 ` [PATCH 07/11] ARM: pci: Keep pci_common_init() " Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` [PATCH 08/11] ARM: tegra: Move tegra_pcie_xclk_clamp() to PMC Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 19:50 ` Stephen Warren
2012-03-08 19:50 ` Stephen Warren
2012-03-08 19:50 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 09/11] ARM: tegra: Rewrite PCIe support as a driver Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 20:09 ` Stephen Warren
2012-03-08 20:09 ` Stephen Warren
2012-03-08 20:09 ` Stephen Warren
2012-03-09 6:37 ` Thierry Reding
2012-03-09 6:37 ` Thierry Reding
2012-03-09 6:37 ` Thierry Reding
2012-03-09 16:42 ` Stephen Warren [this message]
2012-03-09 16:42 ` Stephen Warren
2012-03-09 16:42 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 10/11] ARM: tegra: pcie: Add MSI support Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 21:14 ` Stephen Warren
2012-03-08 21:14 ` Stephen Warren
2012-03-08 21:14 ` Stephen Warren
2012-03-09 6:50 ` Thierry Reding
2012-03-09 6:50 ` Thierry Reding
2012-03-09 6:50 ` Thierry Reding
2012-03-09 16:45 ` Stephen Warren
2012-03-09 16:45 ` Stephen Warren
2012-03-09 16:45 ` Stephen Warren
2012-03-12 8:00 ` Thierry Reding
2012-03-12 8:00 ` Thierry Reding
2012-03-12 8:00 ` Thierry Reding
2012-03-12 16:57 ` Stephen Warren
2012-03-12 16:57 ` Stephen Warren
2012-03-12 16:57 ` Stephen Warren
2012-03-08 14:51 ` [PATCH 11/11] ARM: tegra: pcie: Add device tree support Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 14:51 ` Thierry Reding
2012-03-08 21:31 ` Stephen Warren
2012-03-08 21:31 ` Stephen Warren
2012-03-09 6:31 ` Thierry Reding
2012-03-09 6:31 ` Thierry Reding
2012-03-09 6:31 ` Thierry Reding
2012-03-09 16:47 ` Stephen Warren
2012-03-09 16:47 ` Stephen Warren
2012-03-09 16:47 ` Stephen Warren
2012-03-12 12:06 ` Mark Brown
2012-03-12 12:06 ` Mark Brown
2012-03-12 12:06 ` Mark Brown
2012-03-12 14:17 ` Thierry Reding
2012-03-12 14:17 ` Thierry Reding
2012-03-12 14:23 ` Mark Brown
2012-03-12 14:23 ` Mark Brown
2012-03-12 14:23 ` Mark Brown
2012-03-12 14:28 ` Thierry Reding
2012-03-12 14:28 ` Thierry Reding
2012-03-12 14:32 ` Mark Brown
2012-03-12 14:32 ` Mark Brown
2012-03-08 15:22 ` [PATCH 00/11] ARM: tegra: Add PCIe " Rob Herring
2012-03-08 15:22 ` Rob Herring
2012-03-08 15:22 ` Rob Herring
2012-03-08 15:43 ` Thierry Reding
2012-03-08 15:43 ` Thierry Reding
2012-03-09 4:54 ` Grant Likely
2012-03-09 4:54 ` Grant Likely
2012-03-18 17:31 ` Olof Johansson
2012-03-18 17:31 ` Olof Johansson
2012-03-18 17:31 ` Olof Johansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A32F8.80001@wwwdotorg.org \
--to=swarren@wwwdotorg.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=ccross@android.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-tegra@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@ti.com \
--cc=olof@lixom.net \
--cc=rob.herring@calxeda.com \
--cc=thierry.reding@avionic-design.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.