Re: [PATCH] arch-powerpc.inc: use default value of TUNE_PKGARCH

[Mark Hatle <mark.hatle@windriver.com>]

On 3/8/12 2:15 PM, Richard Purdie wrote:
> On Tue, 2012-03-06 at 17:20 -0600, Matthew McClintock wrote:
>> We can use the default value for TUNE_PKGARCH, and now we just
>> append "-nf" if TARGET_FPU is fpu-soft
>>
>> Signed-off-by: Matthew McClintock<msm@freescale.com>
>> ---
>>   meta/conf/machine/include/powerpc/arch-powerpc.inc |    6 ++----
>>   1 files changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/meta/conf/machine/include/powerpc/arch-powerpc.inc b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>> index c9b2829..abd72ed 100644
>> --- a/meta/conf/machine/include/powerpc/arch-powerpc.inc
>> +++ b/meta/conf/machine/include/powerpc/arch-powerpc.inc
>> @@ -18,10 +18,8 @@ TARGET_FPU .= "${@bb.utils.contains("TUNE_FEATURES", "fpu-soft", "soft", "", d)}
>>
>>   ABIEXTENSION = "${@['','spe'][d.getVar('TARGET_FPU', True) in ['ppc-efd', 'ppc-efs']]}"
>>
>> -PPCPKGSFX_FPU = "${@bb.utils.contains("TUNE_FEATURES", "fpu-hard" , "", "-nf", d)}"
>> -
>> -PPCPKGARCH = "${TUNE_ARCH}${PPCPKGSFX_FPU}"
>> -TUNE_PKGARCH ?= "${PPCPKGARCH}"
>> +PPCPKGSFX_FPU = "${@['', '-nf'][bb.data.getVar('TARGET_FPU',d,1) in ['fpu-soft']]}"
>> +TUNE_PKGARCH_append = "${PPCPKGSFX_FPU}"
>
> Can we please do d.getVar(xxx, True) and not bb.data and ,1 :)

This was originally done with a check for fpu-hard and not fpu-soft to ensure 
that fpu-soft became the default value when one or the other wasn't set.

I don't know if it really matters which is used, but that is why it was done 
that way.

--Mark

> Cheers,
>
> Richard
>
>
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.linuxtogo.org/cgi-bin/mailman/listinfo/openembedded-core