From: "H. Peter Anvin" <hpa@zytor.com>
To: Kees Cook <keescook@chromium.org>
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>,
x86@kernel.org, Andy Lutomirski <luto@mit.edu>,
Hidetoshi Seto <seto.hidetoshi@jp.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mike Frysinger <vapier@gentoo.org>,
Borislav Petkov <borislav.petkov@amd.com>,
Steven Rostedt <rostedt@goodmis.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Subject: Re: [PATCH] x86: use enum instead of literals for trap values
Date: Fri, 09 Mar 2012 09:57:33 -0800 [thread overview]
Message-ID: <4F5A448D.70605@zytor.com> (raw)
In-Reply-To: <CAGXu5j+SgWMjwNQd8w8DPSQmBVHDow=_osp57OVp4X2VU5Fe5w@mail.gmail.com>
On 03/09/2012 08:30 AM, Kees Cook wrote:
> On Fri, Mar 9, 2012 at 1:28 AM, Ingo Molnar <mingo@elte.hu> wrote:
>>
>> * Kees Cook <keescook@chromium.org> wrote:
>>
>>> The traps are referred to by their numbers and it can be difficult to
>>> understand them while reading the code without context. This patch adds
>>> enumeration of the trap numbers and replaces the numbers with the correct
>>> enum for x86.
>>>
I have to admit personally to prefer something like X86_XCP_XX where XX
is the two-letter code that the Intel documentation uses for that trap,
i.e. #GP, #BR, #MC and so on.
-hpa
next prev parent reply other threads:[~2012-03-09 17:58 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 7:42 [PATCH] x86: use enum instead of literals for trap values Kees Cook
2012-03-09 9:28 ` Ingo Molnar
2012-03-09 16:30 ` Kees Cook
2012-03-09 17:57 ` H. Peter Anvin [this message]
2012-03-09 18:21 ` Kees Cook
2012-03-09 18:28 ` Borislav Petkov
2012-03-09 18:52 ` Steven Rostedt
2012-03-09 20:10 ` H. Peter Anvin
2012-03-09 22:13 ` Ingo Molnar
2012-03-09 22:23 ` H. Peter Anvin
2012-03-10 8:34 ` Pekka Enberg
2012-03-09 18:54 ` Kees Cook
2012-03-09 19:08 ` Borislav Petkov
2012-03-09 19:14 ` Steven Rostedt
2012-03-09 19:58 ` Kees Cook
2012-03-09 20:13 ` H. Peter Anvin
2012-03-09 20:21 ` Steven Rostedt
2012-03-10 10:15 ` Borislav Petkov
2012-03-10 13:54 ` Steven Rostedt
2012-03-10 14:27 ` Borislav Petkov
2012-03-11 7:52 ` Alexey Dobriyan
-- strict thread matches above, loose matches on Subject: below --
2013-01-22 22:44 [PATCH] x86: Use " John Kacur
2013-01-22 22:44 ` John Kacur
2013-02-01 17:18 ` Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A448D.70605@zytor.com \
--to=hpa@zytor.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=borislav.petkov@amd.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@mit.edu \
--cc=mingo@elte.hu \
--cc=mingo@redhat.com \
--cc=rostedt@goodmis.org \
--cc=seto.hidetoshi@jp.fujitsu.com \
--cc=tglx@linutronix.de \
--cc=vapier@gentoo.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.