Re: [PATCH v2] ARM: Exynos: JPEG board definition and device register

[Kukjin Kim <kgene.kim@samsung.com>]

Andrzej Pietrasiewicz wrote:
> Hello Tushar,
>
> On Wednesday, February 01, 2012 10:16 AM Tushar Behera wrote:

[...]

>>>
>> [snip]
>>>
>>> +#ifdef CONFIG_S5P_DEV_JPEG
>>> +static struct resource s5p_jpeg_resource[] = {
>>> +	[0] = {
>>> +		.start	= S5P_PA_JPEG,
>>> +		.end	= S5P_PA_JPEG + SZ_4K - 1,
>>> +		.flags	= IORESOURCE_MEM,
>>> +	},
>>> +	[1] = {
>>> +		.start	= IRQ_JPEG,
>>> +		.end	= IRQ_JPEG,
>>> +		.flags	= IORESOURCE_IRQ,
>>> +	},
>>> +};
>>
>> Should be using DEFINE_RES_MEM and DEFINE_RES_IRQ.
>>
> Thank you for pointing this out. I will fix it.
>
Probably, I didn't get updated this so now happens build error about 
lack of s5p_device_jpeg.

>> Also, wouldn't be a good idea to split this patch into 2 different
>> patches for platform-specific and board-specific changes?
>>
> I think I will split it into 3 patches: platform-specific and
> 2 board-specific (universal, nuri).
>
Yes, please re-submit adding platform_device of jpeg. If not, I should 
drop regarding patches in my tree for upcoming merge window.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.