From: Anthony Liguori <aliguori@us.ibm.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: "pbonzini@redhat.com" <pbonzini@redhat.com>,
"quintela@redhat.com" <quintela@redhat.com>,
"qemu-devel@nongnu.org" <qemu-devel@nongnu.org>,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors
Date: Fri, 09 Mar 2012 12:31:52 -0600 [thread overview]
Message-ID: <4F5A4C98.6050401@us.ibm.com> (raw)
In-Reply-To: <4F5A4A08.8030805@siemens.com>
On 03/09/2012 12:20 PM, Jan Kiszka wrote:
> On 2012-03-09 19:13, Luiz Capitulino wrote:
>> The Monitor object is passed back and forth within the migration/savevm
>> code so that it can print errors and progress to the user.
>>
>> However, that approach assumes a HMP monitor, being completely invalid
>> in QMP.
>>
>> This commit drops almost every single usage of the Monitor object, all
>> monitor_printf() calls have been converted into DPRINTF() ones.
>
> I guess for most printfs, this is OK. But do you provide an alternative
> for the block migration progress output? I did not find anything on
> first glance. That is not a debugging feature.
The block migration progress stuff is horribly broken and I regret ever merging
it. Are you actively relying on this?
Does block migration even work?
Could we just remove block migration entirely...
Regards,
Anthony Liguori
>
> Jan
>
next prev parent reply other threads:[~2012-03-09 18:32 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 18:13 [Qemu-devel] [PATCH v2 0/4] qapi: Convert migrate Luiz Capitulino
2012-03-09 18:13 ` [Qemu-devel] [PATCH 1/4] QError: Introduce new errors for the migration command Luiz Capitulino
2012-03-09 18:13 ` [Qemu-devel] [PATCH 2/4] Error: Introduce error_copy() Luiz Capitulino
2012-03-09 18:13 ` [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors Luiz Capitulino
2012-03-09 18:20 ` Jan Kiszka
2012-03-09 18:30 ` Luiz Capitulino
2012-03-09 19:05 ` Jan Kiszka
2012-03-09 19:12 ` Anthony Liguori
2012-03-09 19:48 ` Luiz Capitulino
2012-03-09 19:57 ` Luiz Capitulino
2012-03-12 14:51 ` Kevin Wolf
2012-03-12 15:01 ` Luiz Capitulino
2012-03-09 18:31 ` Anthony Liguori [this message]
2012-03-09 18:45 ` Eric Blake
2012-03-09 18:53 ` Anthony Liguori
2012-03-09 19:42 ` Eric Blake
2012-03-09 19:48 ` Eric Blake
2012-03-09 18:59 ` Jan Kiszka
2012-03-09 18:13 ` [Qemu-devel] [PATCH 4/4] qapi: Convert migrate Luiz Capitulino
2012-03-09 18:26 ` Eric Blake
2012-03-09 18:33 ` Luiz Capitulino
2012-03-09 18:35 ` Anthony Liguori
2012-03-09 18:37 ` Luiz Capitulino
2012-03-09 22:51 ` Alon Levy
2012-03-12 13:21 ` Luiz Capitulino
2012-03-12 13:49 ` Alon Levy
2012-03-12 14:01 ` Luiz Capitulino
2012-03-12 14:23 ` Alon Levy
2012-03-12 14:34 ` Luiz Capitulino
-- strict thread matches above, loose matches on Subject: below --
2012-03-12 19:58 [Qemu-devel] [PATCH v3 0/4] " Luiz Capitulino
2012-03-12 19:58 ` [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors Luiz Capitulino
2012-03-16 19:26 [Qemu-devel] [PULL 0/4]: QMP queue Luiz Capitulino
2012-03-16 19:26 ` [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors Luiz Capitulino
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A4C98.6050401@us.ibm.com \
--to=aliguori@us.ibm.com \
--cc=jan.kiszka@siemens.com \
--cc=lcapitulino@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.