From: Kukjin Kim <kgene.kim@samsung.com>
To: Marek Szyprowski <m.szyprowski@samsung.com>
Cc: 'Kukjin Kim' <kgene.kim@samsung.com>,
Andrzej Pietrasiewicz <andrzej.p@samsung.com>,
linux-samsung-soc@vger.kernel.org,
'Kyungmin Park' <kyungmin.park@samsung.com>
Subject: Re: [PATCHv3 1/3] ARM: Exynos: JPEG board definition
Date: Fri, 09 Mar 2012 11:02:11 -0800 [thread overview]
Message-ID: <4F5A53B3.8060806@samsung.com> (raw)
In-Reply-To: <008101cce739$9839f8f0$c8adead0$%szyprowski@samsung.com>
2012-02-09 오전 6:46, Marek Szyprowski 쓴 글:
> Hello,
>
> On Thursday, February 09, 2012 1:28 PM Kukjin Kim wrote:
>
>>> ARM: Exynos: JPEG board definition
>>>
>>
>> [...]
>>
>>>
>>> +#define EXYNOS4_PA_JPEG 0x11840000
>>> +
>>> #define EXYNOS4_PA_G2D 0x12800000
>>>
>>> #define EXYNOS4_PA_I2S0 0x03830000
>>> @@ -164,6 +166,7 @@
>>> #define S5P_PA_FIMC1 EXYNOS4_PA_FIMC1
>>> #define S5P_PA_FIMC2 EXYNOS4_PA_FIMC2
>>> #define S5P_PA_FIMC3 EXYNOS4_PA_FIMC3
>>> +#define S5P_PA_JPEG EXYNOS4_PA_JPEG
>>
>> I'm not sure we _really_ need to re-define for JPEG.
>> Why not just use EXYNOS4_PA_JPEG?
>
> The s5p-jpeg driver can be also used on S5PV210 so this approach seems
> to be fine, the patch only lacks definitions for the S5PV210 series.
>
I mean, if we use still this style, re-definition for physical address
and interrupt number, it will break one kernel image with others.
Anyway, I will apply this and will sort it out next time.
Thanks.
Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.
next prev parent reply other threads:[~2012-03-09 19:02 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 11:19 [PATCHv3 0/3] ARM: Exynos: JPEG board definition and device register Andrzej Pietrasiewicz
2012-02-01 11:19 ` [PATCHv3 1/3] ARM: Exynos: JPEG board definition Andrzej Pietrasiewicz
2012-02-09 12:27 ` Kukjin Kim
2012-02-09 14:46 ` Marek Szyprowski
2012-03-09 19:02 ` Kukjin Kim [this message]
2012-03-10 10:50 ` Kukjin Kim
2012-02-01 11:19 ` [PATCHv3 2/3] ARM: Exynos: Register JPEG on universal_c210 Andrzej Pietrasiewicz
2012-02-09 12:30 ` Kukjin Kim
2012-02-01 11:19 ` [PATCHv3 3/3] ARM: Exynos: Register JPEG on nuri Andrzej Pietrasiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A53B3.8060806@samsung.com \
--to=kgene.kim@samsung.com \
--cc=andrzej.p@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.