From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:50791) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S657v-00015g-9N for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:05:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S657o-00007O-ON for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:05:18 -0500 Received: from goliath.siemens.de ([192.35.17.28]:33011) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S657o-000071-8t for qemu-devel@nongnu.org; Fri, 09 Mar 2012 14:05:12 -0500 Message-ID: <4F5A5463.9010803@siemens.com> Date: Fri, 09 Mar 2012 20:05:07 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <1331316786-7752-1-git-send-email-lcapitulino@redhat.com> <1331316786-7752-4-git-send-email-lcapitulino@redhat.com> <4F5A4A08.8030805@siemens.com> <20120309153019.32846104@doriath.home> In-Reply-To: <20120309153019.32846104@doriath.home> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Luiz Capitulino Cc: "pbonzini@redhat.com" , "aliguori@us.ibm.com" , "qemu-devel@nongnu.org" , "quintela@redhat.com" On 2012-03-09 19:30, Luiz Capitulino wrote: > On Fri, 09 Mar 2012 19:20:56 +0100 > Jan Kiszka wrote: > >> On 2012-03-09 19:13, Luiz Capitulino wrote: >>> The Monitor object is passed back and forth within the migration/savevm >>> code so that it can print errors and progress to the user. >>> >>> However, that approach assumes a HMP monitor, being completely invalid >>> in QMP. >>> >>> This commit drops almost every single usage of the Monitor object, all >>> monitor_printf() calls have been converted into DPRINTF() ones. >> >> I guess for most printfs, this is OK. But do you provide an alternative >> for the block migration progress output? I did not find anything on >> first glance. That is not a debugging feature. > > Can't the info migrate command be used for that? This was introduced for synchronous migration, as usability improvement. Either we expose this feature or we drop it completely. But converting it to a /dev/null output is pointless. Jan -- Siemens AG, Corporate Technology, CT T DE IT 1 Corporate Competence Center Embedded Linux